Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • react
2 results
Blame Permalink
  • Léo Banno-Cloutier's avatar
    49499411
    datastore: reduce DAO abstraction to remove complexity · 49499411
    Léo Banno-Cloutier authored and Adrien Béraud's avatar Adrien Béraud committed 
    StatementList and StatementElement were an attempt at creating our own
ORM for JAMS. However, doing an database query was very verbose on the
caller side, and if the 1st, 2nd or 4th field of StatementElement was
user input, we would be vulnerable to SQL injections. This patch
hardcoded the SQL queries in the DAO, making it easier on SQL expert to
audit the queries.

Change-Id: I4699bf3146a077efe03efd178b6190dfe60c72e9
    49499411
    History
    datastore: reduce DAO abstraction to remove complexity
    Léo Banno-Cloutier authored and Adrien Béraud's avatar Adrien Béraud committed 
    StatementList and StatementElement were an attempt at creating our own
ORM for JAMS. However, doing an database query was very verbose on the
caller side, and if the 1st, 2nd or 4th field of StatementElement was
user input, we would be vulnerable to SQL injections. This patch
hardcoded the SQL queries in the DAO, making it easier on SQL expert to
audit the queries.

Change-Id: I4699bf3146a077efe03efd178b6190dfe60c72e9
Code owners
Assign users and groups as approvers for specific file changes. Learn more.