Skip to content
Snippets Groups Projects
Commit 4314e58d authored by Guillaume Roguez's avatar Guillaume Roguez
Browse files

fix crash when account is removed

Add protections agains nullptr read access in numbercompletionmodel.

Refs #72155
parent 43d98ae0
Branches
Tags
No related merge requests found
...@@ -296,8 +296,9 @@ void NumberCompletionModelPrivate::setPrefix(const QString& str) ...@@ -296,8 +296,9 @@ void NumberCompletionModelPrivate::setPrefix(const QString& str)
q_ptr->endRemoveRows(); q_ptr->endRemoveRows();
} }
for(TemporaryContactMethod* cm : m_hSipIaxTemporaryNumbers) { for(auto cm : m_hSipIaxTemporaryNumbers) {
cm->setUri(m_Prefix); if (cm)
cm->setUri(m_Prefix);
} }
if (m_Prefix.protocolHint() == URI::ProtocolHint::RING) { if (m_Prefix.protocolHint() == URI::ProtocolHint::RING) {
...@@ -336,7 +337,8 @@ void NumberCompletionModelPrivate::updateModel() ...@@ -336,7 +337,8 @@ void NumberCompletionModelPrivate::updateModel()
locateNameRange ( m_Prefix, numbers ); locateNameRange ( m_Prefix, numbers );
locateNumberRange( m_Prefix, numbers ); locateNumberRange( m_Prefix, numbers );
for (TemporaryContactMethod* cm : m_hSipIaxTemporaryNumbers) { for (auto cm : m_hSipIaxTemporaryNumbers) {
if (!cm) continue;
const int weight = getWeight(cm->account()); const int weight = getWeight(cm->account());
if (weight) { if (weight) {
q_ptr->beginInsertRows(QModelIndex(), m_hNumbers.size(), m_hNumbers.size()); q_ptr->beginInsertRows(QModelIndex(), m_hNumbers.size(), m_hNumbers.size());
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment