Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • release/202005
  • release/202001
  • release/201912
  • release/201911
  • release/releaseWindowsTestOne
  • release/releaseTest
  • release/releaseWindowsTest
  • release/windowsReleaseTest
  • release/201910
  • release/qt/201910
  • release/windows-test/201910
  • release/201908
  • release/201906
  • release/201905
  • release/201904
  • release/201903
  • release/201902
  • release/201901
  • release/201812
  • 1.0.0
  • 0.3.0
  • 0.2.1
  • 0.2.0
  • 0.1.0
25 results

jami-libclient

  • Clone with SSH
  • Clone with HTTPS
    • user avatar
    invoke ContactMethod::addCall() even if the call fails
    Stepan Salenikovich authored 
    If the call immediately failed on creation (empty call id returned
by the daemon) the call was not being added to the CM nor the Person
because addCall() was never being called. This created an
inconsistency since the call IS added to the CallModel. Such calls
should either not be added to the CallModel, or else they should be
added to the CM and Person as well. We choose the latter solution
as this is more informative to the user. Otherwise the user has no
way of knowing if the call failed immediately or was just never even
attempted.

Thus this patch ensures ContactMethod::addCall() is called for all
attempted calls. The PhoneDirectoryModel is ammended to not keep
track of statistics for added calls which are in a failed state.

Change-Id: Ie9d2c22a8a9b7fe84d4d02b3887901ac8974130f
Tuleap: #1093
(cherry picked from commit 596f988d)
    5e4f35ac
    History
    user avatar 5e4f35ac
    History
    Name Last commit Last update