Version Request Broken: give the version for one plugin

Gitlab: #13
Change-Id: I32fcf48eada33c3049d79cb50abca20bd0c6e97f

src/controllers/plugins.controller.ts

@@ -303,8 +303,12 @@ export class PluginsController {
               .status(isUploadable ? StatusCodes.OK : StatusCodes.FORBIDDEN)
               .send()
           )
-          .catch(() => res.status(StatusCodes.INTERNAL_SERVER_ERROR).send());
+          .catch(e => {
+            console.log(e);
+            res.status(StatusCodes.INTERNAL_SERVER_ERROR).send();
+          });
       } catch (e) {
+        console.log(e);
         res.status(StatusCodes.INTERNAL_SERVER_ERROR).send();
       }
     });
@@ -407,16 +411,19 @@ export class PluginsController {
     // eslint-disable-next-line @typescript-eslint/no-misused-promises
     this.router.get('/versions/:id', async (req: Request, res: Response) => {
       try {
-        if (req.query.arch === undefined) {
+        if (req.query.arch === undefined || req.params.id === undefined) {
           res.status(StatusCodes.BAD_REQUEST).send();
           return;
         }
-        const versions = await this.pluginsManager.getVersions();
+        const version = await this.pluginsManager.getVersion(
+          req.params.id,
+          req.query.arch as string
+        );
         res
           .status(
-            versions.length === 0 ? StatusCodes.NOT_FOUND : StatusCodes.OK
+            version === undefined ? StatusCodes.NOT_FOUND : StatusCodes.OK
           )
-          .send(versions === undefined ? undefined : versions);
+          .send(version === undefined ? undefined : [{version}]);
         return;
       } catch (e) {
         res.status(StatusCodes.INTERNAL_SERVER_ERROR).send();

src/services/plugins.manager.service.ts

@@ -275,22 +275,29 @@ export class PluginsManager {
     );
   }
 
-  async getVersions(): Promise<Array<{id: string; version: string}>> {
+  async getVersion(id: string, arch: string): Promise<string | undefined> {
+    const plugin = await this.findPlugin(id, arch);
+    return plugin === undefined ? undefined : plugin.version;
+  }
+
+  async getVersions(
+    arch: string
+  ): Promise<Array<{id: string; version: string}>> {
     if (this.plugins.length === 0) {
       await this.setPlugins();
     }
-    const versions: Array<{id: string; version: string}> = [];
-    for (const plugin of this.plugins) {
-      const version = plugin.version;
-      if (version !== undefined) {
-        versions.push({
+    return this.plugins
+      .filter(
+        (plugins: Plugins) =>
+          plugins.arches.includes(arch) && plugins.version !== undefined
+      )
+      .map((plugin: Plugins) => {
+        return {
           id: plugin.id,
-          version,
+          version: plugin.version,
+        };
       });
   }
-    }
-    return versions;
-  }
 
   private async setPlugins(): Promise<void> {
     let dataDirectory = process.env.DATA_DIRECTORY;

tests/plugins.manager.test.ts

@@ -318,7 +318,7 @@ describe('Plugins manager service tests', function () {
             { id: 'plugin3', version: '3.0.0' },
         ];
 
-        const actualVersions = await pluginsManagerService.getVersions();
+        const actualVersions = await pluginsManagerService.getVersions('x64');
 
         expect(actualVersions).toEqual(expectedVersions);
     });