Commit 1846722d authored by Alexandre Lision's avatar Alexandre Lision Committed by Stepan Salenikovich

build: return error value when executing script

make-ring is not returning the right exit status for any shell script
it executes.
By fixing its behaviour, this has highlighted an issue with the OSX
dependencies not being able to be updated with newer versions
This commit returns a fix value of 1 when a shell script returns an
error (exit status != 0) and make sure that every OSX dependency is
properly installed and updated
Reviewed-by: default avatarStepan Salenikovich <>
Change-Id: Iced6d2eeb0d3028a3935e433c461fd20375e2d0b
parent e6567407
......@@ -360,10 +360,8 @@ def execute_script(script, settings=None):
line = line % settings
rv = os.system(line)
if rv != 0:
print('Error executing script! Exit code: %s' % rv,
return False
return True
print('Error executing script! Exit code: %s' % rv, file=sys.stderr)
def validate_args(parsed_args):
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment