pixbufmanipulator: fix crash when CM has no name

If the contactmethod doesn't have a name, we should use the id and don't
try to get the first letter.

Change-Id: I748dd89a1580e3ea7e416f50d88b2e04cfc750e0
Reviewed-by: Philippe Gorley <philippe.gorley@savoirfairelinux.com>

src/native/pixbufmanipulator.cpp

@@ -44,7 +44,16 @@ PixbufManipulator::generateAvatar(const ContactMethod* cm) const
         if (hashName.size() > 0) {
             cm_number = hashName.at(0);
         }
+        // Get the letter to draw
+        if (!cm->bestName().isEmpty()) {
+            // Prioritize the name
             letter = cm->bestName().toUpper().at(0);
+        } else if (!cm->bestId().isEmpty()) {
+            // If the contact has no name, use the id
+            letter = cm->bestId().toUpper().at(0);
+        } else {
+            // R for ring is used
+        }
     }
 
     bool ok;