Update the desktop and appdata files for GNOME and Qt (please advise the location of the files for Android, iOS, iPad)

Thanks!

Why "Unfortunately, could not update the text directly so the suggested text is shown below:" ?

changed the description

Updated release and project_group based on https://github.com/flathub/cx.ring.Ring/pull/6#pullrequestreview-123777538 and https://github.com/flathub/cx.ring.Ring/pull/6#pullrequestreview-123777588, respectively.

Is this the "upstream" location?
https://github.com/flathub/cx.ring.Ring/pull/6#issuecomment-392566041

@sblin Could not see edit button at:
https://git.ring.cx/savoirfairelinux/ring-client-gnome/blob/master/gnome-ring.appdata.xml

Another improvement is to display captions in multiple languages, like French, using:

xml:lang
The language this screenshot image is translated in. This property should only be present if there are multiple images with different locales present. https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html

Do you have a donation webpage?

Thank you

changed the description

removed milestone

@TingPing commented on May 29, 2018

This should be contributed upstream.

Could you please implement this? Thank you

@ovari Do you want to make your first contribution with this issue?

gnome-ring.appdata.xml is located into the root directory of the gnome client. Should be easy :)

added good first bug label

@sblin Don't know how to update the file using the Web Editor. git.ring.cx also doesn't allow us to fork the code. Please help

In fact you have to clone, modify locally, then add gerrit as a remot and push the code.

The doc can be found here: https://git.ring.cx/savoirfairelinux/ring-project/wikis/tutorials/Working-with-gerrit

The link https://git.ring.cx/savoirfairelinux/ring-project/wikis/tutorials/Working-with-gerrit doesn't work. Can you please provide an updated link? Thank you

https://git.jami.net/savoirfairelinux/jami-project/-/wikis/tutorials/Working-with-gerrit

Thanks.

You'll also need to upload an SSH key to be able to commit changes for review.

Couldn't see in the instructions where we obtain an SSH key. Can you please help? Thank you

You need to create a ssh key and copy the .pub file. First tutorial I get:

https://cloud.ibm.com/docs/ssh-keys?topic=ssh-keys-generating-and-using-ssh-keys-for-remote-host-authentication

But yeah ssh-keygen then add the key to your ssh-agent via ssh-add key and the .pub can be copied

Note to self: .pub file means public key file

yes

$ ssh-keygen
$ sudo apt install git
$ ssh-add
$ ssh-copy-id -i /home/c/.ssh/id_rsa.pub ovari@review.jami.net

Asked for a password. What is the password? Typed something, which was probably not the password that it wanted. Then pressed Ctrl+C

Tried again and now Network is unreachable

$ ssh-copy-id -i /home/c/.ssh/id_rsa.pub ovari@review.jami.net
/usr/bin/ssh-copy-id: INFO: Source of key(s) to be installed: "/home/c/.ssh/id_rsa.pub"
/usr/bin/ssh-copy-id: INFO: attempting to log in with the new key(s), to filter out any that are already installed

/usr/bin/ssh-copy-id: ERROR: ssh: connect to host review.jami.net port 22: Network is unreachable

Should the password be found by clicking on GENERATE NEW PASSWORD at https://review.jami.net/settings/#SSHKeys?

Thank you

you can just copy home/c/.ssh/id_rsa.pub directly in https://review.jami.net/settings/#SSHKeys without ssh-copy-id (New ssh key->Save changes) no need for other credentials

gerrit uses 29420 for ssh not 22

you can just copy home/c/.ssh/id_rsa.pub directly in https://review.jami.net/settings/#SSHKeys without ssh-copy-id (New ssh key->Save changes) no need for other credentials

gerrit uses 29420 for ssh not 22

$ ssh-copy-id -i /home/c/.ssh/id_rsa.pub -p 29420 ovari@review.jami.net
/usr/bin/ssh-copy-id: INFO: Source of key(s) to be installed: "/home/c/.ssh/id_rsa.pub"
/usr/bin/ssh-copy-id: INFO: attempting to log in with the new key(s), to filter out any that are already installed
/usr/bin/ssh-copy-id: INFO: 1 key(s) remain to be installed -- if you are prompted now it is to install the new keys
ovari@review.jami.net: Permission denied (publickey).

This issue's description has been edited with the 3 files attached.

you can just copy home/c/.ssh/id_rsa.pub directly in https://review.jami.net/settings/#SSHKeys without ssh-copy-id (New ssh key->Save changes) no need for other credentials

Copy and paste the contents of home/c/.ssh/id_rsa.pub. Done. Thank you

$ git remote -v 
origin	ssh://ovari@review.jami.net:29420/jami-client-gnome (fetch)
origin	ssh://ovari@review.jami.net:29420/jami-client-gnome (push)
$ git push
Everything up-to-date

Strange as there are 3 files that have been changed.

https://review.jami.net/c/jami-client-gnome/+/19806

Note to self

$ git config --global user.email "you@example.com"
$ git config --global user.name "Your Name"
$ git add jami-gnome.appdata.xml 
$ git add jami-gnome.desktop
$ git add jami-gnome.desktop.autostart 
$ git commit
$ git push origin HEAD:refs/for/master
$ gitdir=$(git rev-parse --git-dir); scp -p -P 29420 ovari@review.jami.net:hooks/commit-msg ${gitdir}/hooks/
$ git commit --amend --no-edit
$ git push origin HEAD:refs/for/master

How does one add Gitlab: #795 to the Commit message at https://review.jami.net/c/jami-client-gnome/+/19806? Thank you

just need to write "GitLab: #795 (closed)" in the commit message, it will be linked to gitlab

https://review.jami.net/c/jami-client-qt/+/19814

Are there equivalent files for Android, macOS, iPad, iOS? Thank you

I don't think so, it's only with store access. Probably FDroid in fdroid-data have a similar file.

https://review.jami.net/c/jami-daemon/+/19832

Thanks for the instructions @sblin. Not sure if our netbook has enough specs to do that. We are happy for anyone to contribute this issue (and take all the credit too). Thank you

P.S. If there was a way we could do this using a web based interface (like GitHub, GitLab, Transifex) we could do it.

changed the description

@Vladimir are you able to update this file too? Thank you

The current screenshots were made for Ring. They should be updated first.

Are there any plans to rename libringclient to libjamiclient? And all project names on Gerrit and GitLab?

Not before a (long) time.

@Vladimir can you use the screenshots at https://jami.net/features/

The screenshots in this page will be updated in a (near) future.

According to the AppStream specification the screenshots should be accessible via HTTP/HTTPS/FTP and be in the PNG or JPEG format. As the project provides the AppStream file in the repository, there is a sense to save some images on the server. Any plans to do so?

changed the description

@ntninja could you please update:
https://gitlab.com/ntninja/net.jami.jami/blob/b05b9160ec1c84f3656f53a76ca4214d47f09865/net.jami.Jami.appdata.xml
with the information in the https://git.jami.net/savoirfairelinux/ring-client-gnome/issues/795 description?

Not sure what the version of Jami is as it just has a build date. @sblin could the jami-client-gnome be built with version numbers like iOS? It will help as the Flathub store maintainers like version numbers.

What do you think?

Thank you

changed the description

Or should https://git.jami.net/savoirfairelinux/ring-client-gnome/commit/853faec537b10b1f075017fd05abbf8fac52ee74 be updated with the description? It would add screenshots with captions and images, etc.

@ovari: The file you linked is not part of regular builds. It was only used for dev builds (testing latest Jami master), until https://git.jami.net/savoirfairelinux/ring-client-gnome/commit/853faec537b10b1f075017fd05abbf8fac52ee74 was merged. As such please send patches about this to the Jami team and they will be shipped when they do the next release.

@ntninja: We only have a netbook computer and don't have the space to create a patch locally. Unfortunately there doesn't seem to be a way to send patches using a web-based interface. Can you help with sending a patch? It will make Jami on Flathub show screenshots etc. Thank you

changed title from Update https://git.ring.cx/savoirfairelinux/ring-client-gnome/blob/master/gnome-ring.appdata.xml to Update https://git.jami.net/savoirfairelinux/ring-client-gnome/blob/master/jami-gnome.appdata.xml

changed the description

mentioned in issue #1117 (closed)

closed

reopened

changed the description

changed title from Update https://git.jami.net/savoirfairelinux/ring-client-gnome/blob/master/jami-gnome.appdata.xml to Update https://git.jami.net/savoirfairelinux/jami-client-gnome/-/tree/master/jami-gnome.appdata.xml{+ and 2 others+}

changed the description

mentioned in commit 7a94edb8

changed title from Update {-https://git.jami.net/savoirfairelinux/jami-client-gnome/-/tree/master/jami-gnome.appdata.xml and 2 others-} to Update the desktop and appdata files for GNOME and Qt (please advise the location of the files for Android, iOS, iPad)

closed

Update the desktop and appdata files for GNOME and Qt (please advise the location of the files for Android, iOS, iPad)

Designs

Child items ...

Activity