Skip to content
Snippets Groups Projects
Select Git revision
  • master default protected
  • release/202005
  • release/202001
  • release/201912
  • release/201911
  • release/releaseWindowsTestOne
  • release/windowsReleaseTest
  • release/releaseTest
  • release/releaseWindowsTest
  • release/201910
  • release/qt/201910
  • release/windows-test/201910
  • release/201908
  • release/201906
  • release/201905
  • release/201904
  • release/201903
  • release/201902
  • release/201901
  • release/201812
  • 4.0.0
  • 2.2.0
  • 2.1.0
  • 2.0.1
  • 2.0.0
  • 1.4.1
  • 1.4.0
  • 1.3.0
  • 1.2.0
  • 1.1.0
30 results

conversation_module.cpp

  • François-Simon Fauteux-Chapleau's avatar
    8f2b6d3f
    conversation_module: update removed contact's conversation exactly once · 8f2b6d3f
    François-Simon Fauteux-Chapleau authored
    When removing a contact, we need to update the ID of its linked
    conversation (to be empty, which is the convention used to signify that
    a contact doesn't have a linked conversation).
    
    This used to be done via the updateConvForContact function, but there
    were two issues (which are fixed by this patch):
    1) if the user had multiple one-to-one conversations with the removed
       contact, then the function would be called multiple times (once per
       conversation) even though the update only needs to be performed once;
    2) more importantly, if the contact's linked conversation ID didn't
       match any of its one-to-one conversations, then the update would not
       be performed at all. (Every contact should normally be linked to a
       valid conversation, but this can fail in practice due to
       synchronization issues.) As a result, the contact would remain linked
       to a conversation that no longer exists.
    
    jami-client-qt#1673
    jami-client-qt#1804
    
    Change-Id: Ia75c5b27a4120bc48da5f449a874354326c6d96a
    8f2b6d3f
    History
    conversation_module: update removed contact's conversation exactly once
    François-Simon Fauteux-Chapleau authored
    When removing a contact, we need to update the ID of its linked
    conversation (to be empty, which is the convention used to signify that
    a contact doesn't have a linked conversation).
    
    This used to be done via the updateConvForContact function, but there
    were two issues (which are fixed by this patch):
    1) if the user had multiple one-to-one conversations with the removed
       contact, then the function would be called multiple times (once per
       conversation) even though the update only needs to be performed once;
    2) more importantly, if the contact's linked conversation ID didn't
       match any of its one-to-one conversations, then the update would not
       be performed at all. (Every contact should normally be linked to a
       valid conversation, but this can fail in practice due to
       synchronization issues.) As a result, the contact would remain linked
       to a conversation that no longer exists.
    
    jami-client-qt#1673
    jami-client-qt#1804
    
    Change-Id: Ia75c5b27a4120bc48da5f449a874354326c6d96a
Code owners
Assign users and groups as approvers for specific file changes. Learn more.