- Uses 1.1.1 stable branch of https://github.com/openssl/openssl
  instead of https://github.com/microsoft/openssl. Note that this
  build will not pass app certification for the Windows store.
- bumps opendht to support the new OpenSSL build and removes some
  unused linkage
- adds a 'use_cmake' key to the package.json windows contrib
  build system
- allows us to shave about 4.5 min off openssl build time by
  defining MAKE_TOOL to jom.exe to override nmake
- adds /FS to force synchronous PDB writes

Change-Id: Idd06a0805b45fa19551c15d1859cbccca49e6bb6

Sébastien Blin authored 4 years ago and Adrien Béraud committed 4 years ago

getSIPAccount() is returning a reference to the SIPAccount. Account
that can be destroyed and if a mistake is made, the data can be
invalidated, generally even when closing the daemon.

This patch change the behavior of getSIPAccount() to return a
weak_ptr to make sure that the Account is alive when performing
actions on the call

Change-Id: I1dcc05bce0c9826297535b5a5224f9ff22479d80

Sébastien Blin authored 4 years ago and Adrien Béraud committed 4 years ago

Change-Id: Ife2fc6bf69c1e0ab81ab04616f1c31dbfd81e421

Sébastien Blin authored 4 years ago and Adrien Béraud committed 4 years ago

Change-Id: I5beb8f45ad50baf2d2dd5bf1be4dbd6cbb1e3cc5

Sébastien Blin authored 4 years ago and Adrien Béraud committed 4 years ago

Change-Id: Iba70968516278b1b7391645a805bdcc0cd73ac0e

Sébastien Blin authored 4 years ago and Adrien Béraud committed 4 years ago

To avoid conversions.

Change-Id: I0a37cb2172be38da63df2ca091197042be4f65e2

charconv is included by cpp>8.1, so we need to build the daemon
with libstdc++-8-dev and avoid the usage of g++7. Also remove
the docker for ubuntu 16 as we don't build for this version anymore.

Change-Id: If5b62996d3b84891b03b7a799989ed57dfeec589

Sébastien Blin authored 4 years ago and Adrien Béraud committed 4 years ago

Also makes ftp server non blocking

Change-Id: I26a3804a04c61274c064662d678b65747ff8ddc9

Sébastien Blin authored 4 years ago and Adrien Béraud committed 4 years ago

When the negotiation is done, the previous sockets are closed
So, when iterating over the sockets, check if the sock is not
closed.

Change-Id: Id5250c30aa4f1cbacf8276d1530c39a5bcae9b8a
GitLab: #257

Sébastien Le Stum authored 4 years ago and Sébastien Blin committed 4 years ago

Replace that unsafe behavior by a better erase + remove_if logic.

Change-Id: I388357653449524b83c9776c169e1104160fec57

Aline Gondim Santos authored 4 years ago and Adrien Béraud committed 4 years ago

Change-Id: Iebb5804098699ca206a506cf8e1362faf1ef1aff

Sandra Tobajas authored 4 years ago and Sébastien Blin committed 4 years ago

Add armhf processor architecture and specific CFLAGS to be able to build
libressl for an armhf platform.

Change-Id: If563fbf2a998d6d4a4cc158e437bfbad3f8b397a

Sébastien Blin authored 4 years ago and Andreas Traczyk committed 4 years ago

Change-Id: I06b505620ec980af97a5ee5b8526b5a1efdd4bee

Change-Id: I0c2a06afd0a3c73bb64a64ece119f7ea65f54064

Pierre Lespagnol authored 4 years ago and Adrien Béraud committed 4 years ago

Change-Id: I89bc1c2f4012f84b86e5a12ee03dc40513a4f7a6

Change-Id: I120fbac7f5bbcfbb7341b903741c04045759f52b

Sébastien Le Stum authored 4 years ago and Adrien Béraud committed 4 years ago

Ensure that there won't be buffer overflows by enforcing the maximum
size for each string read.

Change-Id: I662d46c4c22ca2784a5518fb46a1023cad09256e

Sébastien Le Stum authored 4 years ago and Sébastien Blin committed 4 years ago

Using release() on a unique_ptr container will transfer the ownership
and actually empty the unique_ptr, leaving it NULL.

Fix a potential use-after-free if the send_request fails by scoping in
the release of the context pointer.

Change-Id: I495964fd9b0edd24b528649bace679369a967dd5

Sébastien Le Stum authored 4 years ago and Adrien Béraud committed 4 years ago

This value is used in getAccountList() to reserve the size of the final
vector that will group all the account pointers.

Change-Id: Id2b0ae149b08b7962123d9e7533fe3c34e8d4750

Change-Id: I605b6ccccb83ee482a34640ba71cb9c0d548502f

Change-Id: I27edb0b8018108d10a903b7349e2eae5e8a6544e

Sébastien Le Stum authored 4 years ago and Sébastien Blin committed 4 years ago

This feature is mostly a relicate from SFLPhone and introduced a remote
attack vector abusing the system() function weaknesses.

Provided that "sipEnabled" parameter is on in the remote target's
configuration, a malicious peer calling that remote target could
send SIP messages with a crafted "X-ring-url" string in order to
execute arbitrary shell commands on the target.

Header entry "X-ring-url" content is actually consumed by UrlHook
as arguments for the "x-www-browser" command executed using system().

By adding a shell escape sequence to circumvent existing arguments
sanitizing attempts, the malicious peer could execute any shell command
under remote peer user's identity and access sensitive information
available using its privileges.

Remove that feature altogether and enforce users that are relying on
that feature to migrate to Jami "plugins", which are more suitable
for introducing custom Jami behaviors.

Change-Id: I1d6d07771e2b5a7c7f2cb8fc838821106c0a6708

Change-Id: I0a69785156f2e68c61fac03516f671029815f112

Change-Id: I1fbe97ae840318c4cd6a3b4022bd0aa9335dc5ce

Change-Id: I5fca86eb620043998e7a41a2b7bca12642567376

Kateryna Kostiuk authored 4 years ago and Adrien Béraud committed 4 years ago

Change-Id: I723629cfab93861e9759da5eda06de220f5cf544

Pierre Lespagnol authored 4 years ago and Adrien Béraud committed 4 years ago

Change-Id: I3f15e30823a35f61366069f25e3f9d65af449b8c

Since all is async, sometimes, it's possible to call setupLocalSDPFromIce
before that initIceMediaTransport is done, stopping the call in a weird
way.

Change-Id: I5e329a4a44db61e24ac559535a4f6c72f4527ae4

Sébastien Blin authored 4 years ago and Adrien Béraud committed 4 years ago

All structures are now stored in a map<<InfoHash, Vid>, ConnectionInfo> instead
of 3 maps to manipulate states. This avoids a lot of complexity and potential
crashes

Change-Id: I003c4bd9a94b6c160911e2dcc8c4a15835a749c9

Sébastien Blin authored 4 years ago and Adrien Béraud committed 4 years ago

Callbacks MUST be used. This patch remove the usage of waitForInitialization
and waitForNegotiation in connectionManager

Change-Id: I2be7e3b931e3d6ab7bcd71c51eca63f48668264c

The code to start a call from a socket should only be done for calls in
SEARCHING... Also, DISCONNECTED is state 0, so the condition didn't work
for non connected calls.

Change-Id: I65132c12f1be2ecae8e003bd4028f8b16c26001b

When using AV_PIX_FMT_VIDEOTOOLBOX as codec context pixel format
videotoolbox encoder will expect all frames to have format
AV_PIX_FMT_VIDEOTOOLBOX. And that is not the case for conference.
This patch change codec context pixel format to AV_PIX_FMT_NV12.

Change-Id: I1dce38786b0ad5999a8f6b701abf50c2570782b0

Previous implementation was introducing ambiguity on a
potential off-by-one.

Rework the statement so it is clear that char_file_end
is to be considered as collection's end().

Change-Id: I7af6f9333c80c8a897ff21ca5ccfe2a2c268546d

Change-Id: I80102b0df5e6fa24f9686e1bc03e38180cb9b958

Change-Id: If9665ff40b4e8fff09d66bdb9c0fb557dafbe0c0

Also fix layout for audio only

Change-Id: Ia1f9d20779a7e2c3e9ff630d50612b1bcaf0f33d

Larbi Gharib authored 4 years ago and Adrien Béraud committed 4 years ago

Change-Id: Id569c9213be79c1864d458e491b68a3e9ad94eef

Pierre Lespagnol authored 4 years ago and Adrien Béraud committed 4 years ago

Change-Id: Id1046f0f37bacf2687da0e37893817ae0bdab162

Pierre Lespagnol authored 4 years ago and Adrien Béraud committed 4 years ago

The encoder reinitialization cause a bad rendering (pixel effects)

Change-Id: Ic6b43d22532073f3c60d2e796ebb406a96858b4d

Sébastien Le Stum authored 4 years ago and Sébastien Blin committed 4 years ago

Remove potential NULL pointer dereference in the case of plugin
pointer being NULL.

Change-Id: Iaf7fd6c4d0c44983723827dbba89f18136c8954a