Skip to content
Snippets Groups Projects
Commit 37c44a1b authored by Alexandre Eberhardt's avatar Alexandre Eberhardt
Browse files

OCSP: fix 404 error caused by null extension

Extensions object cannot be constructed with empty Extension.
However, an extension is not required in addResponse function
Corrected the issue by splitting the function between those two cases
Gitlab: #151

Change-Id: I584329ee88457d88198ab3d1457ff41c2b00c40a
parent a8fc4c92
No related branches found
No related tags found
No related merge requests found
......@@ -162,19 +162,25 @@ public class OCSPWorker extends X509Worker<String> {
throws OCSPException {
CertificateID certificateID = request.getCertID();
// Build Extensions
Extensions extensions = new Extensions(new Extension[] {});
Extensions requestExtensions = request.getSingleRequestExtensions();
if (requestExtensions != null) {
Extension nonceExtension =
requestExtensions.getExtension(OCSPObjectIdentifiers.id_pkix_ocsp_nonce);
if (nonceExtension != null) extensions = new Extensions(nonceExtension);
Extensions extensions = new Extensions(nonceExtension);
responseBuilder.addResponse(
certificateID,
OCSPCertificateStatusMapper.getStatus(
getCertificateSummary(request.getCertID().getSerialNumber(), unknown)),
new Date(),
new Date(new Date().getTime() + crlLifetime),
extensions);
} else {
responseBuilder.addResponse(
certificateID,
OCSPCertificateStatusMapper.getStatus(
getCertificateSummary(request.getCertID().getSerialNumber(), unknown)),
new Date(),
new Date(new Date().getTime() + crlLifetime));
}
responseBuilder.addResponse(
certificateID,
OCSPCertificateStatusMapper.getStatus(
getCertificateSummary(request.getCertID().getSerialNumber(), unknown)),
new Date(),
new Date(new Date().getTime() + crlLifetime),
extensions);
}
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment