Blocking contact does not work, removed/blocked contact can be called? [Android-> Windows 10]

newest beta version of Jami (Windows 10 and Android); 1:1 swarm, using different Jami accounts Windows 10= username1; Android=username2; group chat disabled;

EDIT: Just the Windows 10 user enabled "Allow incoming calls from unknown contacts"

steps to reproduce

1. both contacts (Windows 10 user and Android user) are each showing up in their contact list

2. Windows 10 user removes the Android contact in contact list (However the Android user does not)

3. Android user writes message (Android -> Windows 10)

4. Windows 10 user does not receive the message

5. Now the android makes a phone call

6. Windows 10 receives the phone call; He can hear the ringtone but won't get the options to decline or answer in audio/video

7. Now the Windows 10 user exits and restarts jami (The Android user keeps Jami running)

8. Now the Android user tries to make a phone call (android -> windows 10)

9. Windows 10 user does not get any notification

Android user exit and start Jami again Android user still sees green dot of Windows 10 user Windows 10 user does not get any notification (same issue again)

Next issue:

1. Now the Windows 10 user unblocks the Android
2. The android user sends text message
3. The Windows 10 user gets an invitation and accepts
4. The Windows 10 user still sees the notification "invitations 1"
5. Jami Windows 10 still shows invitations but the user does not receive any message

However you can make a video call Android -> Windows 10 but Jami (Windows 10) does not show up chat history

Next issue: (after the previous issue)

1. Restart Jami (just the user of Windows 10)
2. You can view the same (Android) user twice (Both: Swarm: Is true); It is still not possible that the Windows 10 user receives any text message (Android -> Windows 10) and it is also not possible to receive text messages Windows 10 -> Android

However video call Windows 10 <-> Android are possible

If you restart Jami (windows 10) same issue again (And you still won't receive any messages anymore although windows 10 contact is unblocked)

---

Now remove the contacts (Windows 10 AND Android; exit all Jami apps)

Windows 10 user: As soon as you remove the (unblocked) Android - you just want to delete the contact - the Android user will be listed in "blocked contacts" (although you did not block the user (again)). You won't be able to delete the Android user anymore - the user will always be moved to "blocked contacts".

---

Now Android -> Windows 10 (all contacts (windows 10 and Android) were removed)

Android: Add the Windows 10 user by searching the user name and add the Windows 10 user Sending text messages Android <-> Windows 10 now works

Now:

1. The Android user blocks the Windows 10 user (If the Android user tabs the Windows 10 user (from the conversation list) block contact does not work)
2. So the Android user needs to go to contact details and block the Windows 10 contact and confirms
3. However the Windows 10 user DOES NOT remove the android user from his contact list
4. Android: even if you stay (conversation - tap the contact) you won't receive any new messages (from the Windows 10 user)
5. Now return to conversations: the blocked user is gone

However: As soon as the Windows 10 user makes a video call your blocked contact will be shown again (conversations) and you get a notification how you want to answer the call (although both contacts disabled "Allow calls from unknown contacts")

After you finished the call you are asked if you accept the invetation of the blocked Windows 10 user. If the Android user accepts: The Android user can send messages but the windows 10 user will not receive them

However - the android user will still receive messages (windows 10 -> Android) If the android user taps "blocked contact" Windows 10 user is still shown and you can't change anything.

I just saw the Windows 10 user did enable "Allow incoming calls from unknown contacts". I'll check if I have the same issue again.

EDIT: Android: I just saw after exit and start Jami again I now have the Windows 10 user twice in the contact list.

EDIT 2: Even if I disable "Allow incoming calls from unknown contacts" I think I still get this issue.

changed the description

assigned to @sblin

will check

Allow incoming calls from unknown contacts

is not related to banning someone. If someone is banned, all request must be declined

Thanks! Can you and the team also check if this issue persists /appears if you use group chat (/group-swarm call as soon as available)?

Not sure if this is related to this issue? https://forum.jami.net/t/dont-receive-a-friend-request/1420/19

I tested the group chat with 2 phones, and at first it was working, then all of the sudden one of them couldnt receive the messages anymore.

@sblin

Next issue: Steps to reproduce:

1. Windows 10 unblock contact (I tried to delete the contact but it is not possible -> The Android contact shows up in "blocked contacts")
2. Windows 10: Block Android contact (however: Windows 10 user does not exit Jami)
3. Android user: exit Jami
4. Android user: open Jami
5. Now the Android user can view 5 times the same Windows 10 user (conversation list)
6. The Android user now deletes the 4 (more) accounts in the conversation list so you the Android user just views one Windows 10 user
7. Windows 10 user starts Jami again. The android user is shown in the contact list.
8. As soon as the Android user wants to write a text message the Windows 10 user won't get the message but an invitation
9. The Windows 10 user accepts but still does not receive the text message
10. Now the Windows 10 user exits Jami
11. Now the Windows 10 user can view the same contact twice in the contact list (one is showing "Swarm created" and the other same contact is showing "You have accepted the conversation request", Waiting until usernamexy connects to synchronize the conversation.) BOTH (Swarm: Is true)
12. The Android sends a text message but the Windows 10 user won't get any text message (neither the first account nor the second (same) account)
13. Neither the Windows 10 user nor the Android user will get any message (Windows 10 <-> Android)
14. The Windows 10 user exits Jami (but not the Android user)
15. Still - no one can receive text messages
16. Now just the Android user exits Jami
17. Still not possible to receive text messages (both)
18. Now both users exit Jami
19. Still no difference
20. Windows 10 user now delets one contact (the one showing "You have accepted the conversation request", Waiting until usernamexy connects to synchronize the conversation.)
21. Windows 10: both (same) accounts from the Android user are gone after deleting but the (one, Android) "deleted" account is shown under "blocked contacts (Windows 10)
22. Windows 10: Now unblock the "deleted" user
23. The Android user sends a text message
24. The Windows 10 user does not receive the text message but an invitation. (Now go to step 8 again, you should be able to reproduce now)

How I can fix this issue so I can get all text messages again:

1. Delete all contacts (Windows 10 and Android) [I think the Android contact is actually more important?]
2. Windows 10: The "deleted" contact shows up in "blocked contacts".
3. Windows 10: Unblock the "deleted" blocked contact (Select "Reinstate as contact")
4. Android user: search the (Jami-)username in the search field
5. Android user: select add to contacts
6. I takes some time (a few seconds)
7. Now both contacts communicate with each other (again)

However - Think it is still possible to call (a blocked and/or non-working user) even if sending text messages does not work.

unassigned @sblin

To be honest this issue is unreadable. There is like 5 issues and some with 24 steps.. Please again avoid multiple posts. There is also a template dedicated for readability when creating new tickets.

So let's start. In the first scenario do you block or remove the conversation? Cause the issue is about blocking (which seems fine on my devices) and you talk about removing the conversation (which is completely different as it's not blocking).

Windows 10 user removes the Android contact in contact list (However the Android user does not)

Sorry ... but many issues appeared at once.

So ... I actually meant "block" NOT delete the contact. After that my contact is removed (by Jami?) from the contact list.

I just reproduced but this time after step 6 (the first description) I received an invitation notification (Windows 10) but without an actual invitation (to accept or to decline).

As soon as you make phone call (Android -> blocked user (the user that blocked the Android user) you'll get this issue:

Windows 10 receives the phone call; He can hear the ringtone but won't get the options to decline or answer in audio/video

But this time together with this issue:

I received an invitation notification (Windows 10) but without an actual invitation (to accept or to decline).

yeah only keep once or clearly separate the issues. 6 scenarios for 1 issues is just unclear for everybody else. It's just one issue with several things, or several issues with distinct scenarios.

So: Alice (Android)/Bob (windows) (versions?)

1. Bob blocks Alice
2. Alice sends a message (is this step necessary? or without this step you have the issue?)
3. Alice calls bob => Bug, you have a Ringtone sound

With 1/3 or 1/2/3 I can't reproduce on several devices. Logs clearly reject the connection and no call is made, so there is something weird

Alice: Android (EMUI 12) 20220615-01 Bob: Windows 10: Jami (beta-)Version 202206231612

1. Bob blocks Alice
2. Alice is automatically removed by Jami and not visible in the contact list (of Bob) anymore
3. However - Alice did NOT block Bob
4. Alice tries to send a message to Bob - but of course Bob does not receive the message anymore.
5. Now Alice makes a video call (Alice -> bob)
6. Bob can hear the ringtone but won't have a menu to decline or accept

EDIT: After some time (~ a few (30?)seconds later) Bob recieves an invitation notification without any contact or option to accept or decline.

@atraczyk do you reproduce? I don't have windows, but as far as I test, with latest client-qt everything is fien and I don't reproduce

@sblin Can you reproduce the other way? Not Windows 10 -> Android but Android -> Windows 10 (or a Linux-Distro)?

Would this be an issue regarding the daemon or regarding to the client?

Steps would be:

1. Alice blocks Bob (but Bob does not block Alice) [Tap the contact-> contact details-> block contact(Bob)]
2. Alice won't receive any (text) messages from Bob
3. As soon as Alice leaves the conversation with Bob (now blocked) and returns to the whole conversation list Bob is gone
4. Now Bob calls Alice
5. Alice gets an invitation from Bob
6. If Alice taps the invitation (she does neither accept nor decline the (blocked) contact) she will view a notification "Return to ongoing call" and will now be able to make a phone call
7. After that she can decide if she wants to accept or decline the (blocked) contact (Bob)
8. If she accepted Bob will be in the contact list again

mentioned in issue jami-client-android#1108 (closed)

the next nightly will have some fixes for blocking/unblocking contacts (desktop)

Ok - Thanks for the info!

Alice: Android (EMUI 12) 20220615-01 Bob: Windows 10: Jami (beta-)Version 202206231612

@sblin Can you reproduce the following issue:

1. Bob unblocks Alice (Settings > Account > blocked contacts)
2. Alice is now displayed in the contact list again
3. Bob: uses right click delete (NOT block!) to delete Alice (remove Alice from contact list)
4. However: If Bob returns to Settings > Account > blocked contacts - Alice now appears again - although Bob did NOT block the contact (Alice; again) but deleted Alice
5. Now Bob selects "Reinstate as contact"
6. Suddenly Alice is shown in the contact list again - so she was blocked but NOT deleted?

If you can't reproduce can @atraczyk reproduce this issue and #1449 (comment 36195) )

EDIT: Will this patch also fix these issues?

yes it's exactly the problematic thing introduced in the last nightly, and will be solved in next one

I think you couldn't reproduce #1449 (comment 36195) (using a Linux distro)

So @atraczyk will fix this issue for the Windows 10 client?

mentioned in issue jami-client-qt#776

mentioned in issue #1388 (closed)

Using the newest beta Jami (both; Android and Windows 10 client; beta version 202207191300)

Alice: Android (EMUI 12) 20220615-01 Bob: Windows 10: Jami (beta-)Version 202206231612

1. Bob has Alice twice time in the contact list (jami-client-qt#776 (comment 36392))
2. Bob deletes Alice (just the second (same) Alice contact) from the contact list (but Alice does neither delete nor block Bob in her contact list)
3. All (twice) accounts of Alice are gone in the contact list of Bob
4. Alice sends a message to Bob
5. Bob never receives the message
6. Alice makes a video call (Alice -> Bob)
7. Bob receives the video call and and invitation
8. Bob's Jami version of Windows crashes (jami-client-qt#763 (closed))
9. Just Bob starts Jami (Windows 10 version) again
10. Now Alice will never be able to call bob again

NOW next steps: (Alice NEVER blocked bob or removed Bob from the contacts in the contact list)

1. Bob searches the username of Alice and makes a call
2. You can see "Swarm created"
3. The call fails (Bob just sees "Searching")
4. Also the next calls will fail Bob -> Alice
5. Now Alice makes a call (Alice -> Bob)
6. Bob receives the call
7. Bob ends the call
8. Suddenly bob can make a call (Bob -Alice) [Windows 10 will crash again]

Now Bob starts Jami (Windows 10) again. Alice NEVER exits Jami. Suddenly bob can make a call

another situation:

All peers disabled "Allow incoming calls from unknown contacts", no size limit regarding the attachment

first scenario:

Bob and Alice launch Jami

1. Alice deletes Bob (but Bob does not delete or block Alice)
2. Bob makes a call
3. Alice receives the call of Bob (although no longer in the contact list)
4. Alice exits the call
5. Suddenly Bob is displayed at contact requests
6. Alice adds Bob to the contacts
7. Bob will still be displayed a few ten seconds at contact requests
8. Now Alice calls bob

second scenario:

1. both peers launch jami
2. Alice deletes bob (but Bob does not delete or block Alice)
3. Bob sends a message to Alice
4. Alice receives the message (although Bob is no longer in the contact list)
5. Suddenly bob is displayed in the contact list again (Alice never needs to accept the contact again)
6. After Alice received the text message she taps Bob and “delete contact”
7. However this is not possible
8. She taps Bob and can only view “add to contacts”
9. So she taps contact details
10. Now Alice exits Jami
11. Alice enters Jami again – Bob in the contact list is gone the first 10 seconds but then suddenly appears again

next issue 1: EDIT: I think this bug just happens if the green dot of the Windows 10 user is visible; if the Windows 10 user is "offline" Alice can delete Bob without any issues

1. Alice deletes the contact
2. Alice exits Jami (NOT Bob the Windows 10 user)
3. Alice opens the Android app again: same contact (Windows 10 contact=Bob) is displayed in the contact list (although it sould be deleted)
4. Alice now tries to delete Bob AGAIN
5. Android: the contact now moved from above to below the contact list
6. Alice delets Bob AGAIN
7. Alice can't delete the contact
8. Alice taps the (Windows 10=Bob) contact
9. Alice now gets an invitation from Bob
10. Alice exits Jami
11. Android: The contact (Windows 10=Bob) now is gone

Keep in mind: Only Alice exits Jami; Bob (Windows 10 user) NEVER exits Jami

1. Android: Now Bob (not visible in Alice contact list anymore) makes a call
2. Windows 10: Bob will just get a "Searching" option and the call will fail

Now Bob exits Jami (NOT Alice this time) Bob will just get a "Searching" and the call fails

Now all peers (Windows 10 AND Android) exit Jami

Issue 2: Bob is finally gone All peers exit Jami Alice and Bob enter Jami Now Bob is suddenly again in the contact list Bob can make a call (windows 10 -> Android) Alice tries to delete Bob -> Same issue 1 (follow these steps)

Now: (Seems to work) Bob can't make a call Windows 10 -> Android (just searching and fail contact)

Alice wants to call Bob (again)

Steps:

Alice searches Bob Alice taps add to contacts Now bob can call alice Alice exits Jami

Issue 3:

1. Alice deletes Bob
2. Bob now moved from above to below the contact list (but can't be deleted)
3. Alice (just Alice; NOT Bob) exits Jami
4. Alice opens Jami again - Bob is now gone in the contact list of Alice
5. Bob (never exits Jami; he keeps Jami running) now makes a call: Bob -> Alice (=Windows 10 -> Android)
6. Now Alice will receive a call AND an invitation
7. After Alice finished the call she can accept the invitation
8. However Alice is not able to accept the contact (?if she taps the invitation it immediately closes); Bob is already in the contact list
9. Alice deletes bob in the contact list (the invitation is gone)
10. This will NOT delete Bob but move this contact from above to below the contact list
11. Now just Alice exits Jami (NOT Bob)

Alice will get the same issue start at step 4

EDIT: Maybe the developers can also try Windows 10 -> Android (instead of Android -> Windows 10) etc.

EDIT 2: All peers disabled "Allow incoming calls from unknown contacts", no size limit regarding the attachment

@sblin If I enable "Make all participants moderators" can every participant kick / block or ban each other?

If I disable "Make all participants moderators" can just the host kick and/or block participants?

What will happen regarding group chat / group video calls (Multi-Swarm)?

yes and for group chat this doesn't change anything, it's a call option.

added to-check label

mentioned in issue jami-daemon#750 (closed)

There's also another issue: jami-daemon#750 (comment 36703)

Even if you remove the contact sometimes all devices will remove the contact (if use have the same account with the same contact list on multiple devices)

This time: sameuseraccount <-> sameuseraccount

Windows 10 -> Android

And: After you just removed (NOT blocked) the contact (all devices) If you DON'T select "Add to conversation" but "Make a video call" your contact "test2" will be shown in the android device again

Even if all peers disabled "Allow incoming calls from unknown contacts";

Not sure if you are an "unknown contact" if you make a call sameuseraccount <-> sameuseraccount but your own account is not visible in the contact list?

mentioned in issue jami-client-qt#794 (closed)

I did not do enough test ... but I think Android <-> Android won't allow to call a removed user

changed title from Blocking contact does not work to Blocking contact does not work, removed/blocked contact can be called?

Alice: Android (EMUI 12) newest beta-version Bob: Windows 10: Jami newest beta version Alice removes Bob but does not exit Jami Calls Bob -> Alice (Windows 10 -> Android) don't work anmore so this seems to work

Next/similar issue:

The issue proceeds: (no one exits Jami; Alice and Bob keep Jami running)

Issue a:

1. Just Bob removes Alice
2. Now Alice calls Bob
3. Bob get an invitation with an identifier like 123456abcde; at the same time he can answer the call
4. After the call Bob goes to the invitation and declines the contact 123456abcde- However the invitation still remains

Issue b:

1. Just Bob exits Jami
2. Now Bob opens Jami
3. Bob declines the contact 123456abcde (again; the first time he declined the contact before he left Jami the first time)
4. Now Bob gets a second invitation of 123456abcde
5. Bob declines the second invitation
6. Now all invitations are gone
7. Suddenly Alice can't call Bob anymore (no more calls Android -> Windows 10)

Issue c:

1. Just Alice exits Jami (Android)
2. After some time Bob AND Alice (Windows 10 AND Android) exit Jami
3. Bob will get an invitation again; However- calls are not possible
4. Even if Bob accepts the invitation he always just gets "Waiting until Alice connects to synchronize the conversation."
5. Now just Bob exits Jami
6. However - Bob still only gets "Waiting until Alice connects to synchronize the conversation." - However - calls (both directions) are now possible

Issue d:

1. Bob AND Alice exit Jami
2. Bob removes Alice
3. If ALice makes a call (Android -> Windows 10) Bob will get an invitation
4. Jami crashes because of this issue (jami-client-qt#763 (closed))
5. If Bob restarts Jami no calls are possible anymore

changed title from Blocking contact does not work, removed/blocked contact can be called? to Blocking contact does not work, removed/blocked contact can be called? [Android-> Windows 10]

added SprintIn progress label

Something I didn't check ... but maybe you can check

block and/or remove

• Desktop (Windows 10) <-> Desktop (Windows 10)
• Android <-> Android
• "Jamiaccount1" <-> "Jamiaccount2"
• "sameJamiaccount1" <-> "sameJamiaccount1"

Hi @El4

Lets keep our issues simple as it is not manageable working with all of your coments and multitude of scenarios.

Maybe, and that we can verify only after a fix, all subsequent issues are originated in the same initial bug.

So for now our priority is a single scenario and all others will be temporarily discarded:

• Alice(Windows), Bob(Linux) - both sides on Master

0. Alice and Bob messages and calls works as expected;
1. Alice blocks bob;
2. In different occasions I could have: Bob calls alice and either - empty invitation tab; call appears to Alice; Bob call is searching and fails;
3. Alice unblocks Bob: Alice writes message and sends (it does not appear neither on Alice or Bob chat but Bob can see the typing indicator) Bob writes message and sends (it appears on Bob chat and Alice can see the typing but not the message)

Expected scenario:

0. Alice and Bob messages and calls works as expected;
1. Alice blocks Bob;
2. Bob call is searching and fails;
3. Alice unblocks bob: Alice writes message and sends (it does appear on Alice chat and Bob can see both the typing indicator and the message) Bob writes message and sends (it appears on Bob chat and Alice can see both the typing and the message)

@sblin You may fell free to adjust the basic scenario as you see fit for debugging/testing purposes. I remain available for tests using Windows.

https://review.jami.net/c/jami-daemon/+/22238

removed SprintIn progress label

added bug label and removed to-check label

assigned to @sblin

I think my scenario was (I always did a test Android -> Windows 10; "Jamiaccount1"->"Jamiaccount2"):

2. Bob (now blocked; Android user;) calls Alice (since she is still in the contact list of Bob;) Alice will get an invitation and she'll be able to answer the call (although both peers disabled "Allow incoming calls from unknown contacts").

Maybe you can also test if you can make a call Android <-> Windows 10 ("sameuseraccount1"<->"sameuseraccount1" and "account1"<->"account2") to a contact that was NEVER added on the device of Alice and / or Bob. Because I think you (Android user) can also call (Windows 10) contacts you never had in your contact list before although both peers disabled "Allow incoming calls from unknown contacts".

If you reproduce between android-windows and we reproduce between windows-linux then the issue is something not related to the devices we use for test and the platform should not impact the end fix.

As stated before, we will ignore all issues branched from the scenario detailled in my last comment until this first fix is in place. Then, and only then, we will check the other issues you mentioned.

Not sure ... but maybe your issue 3 is also releated to this issue (jami-client-qt#776; Option B)? I know it might get complicated ...

If it is related/the same issue we will link the tickets in time.

added SprintTo review label

mentioned in commit jami-daemon@1f77dce5

mentioned in commit jami-daemon@cb3d3c3c

those scenarios should be fixed with the next version (both sides must be patched)

closed

removed SprintTo review label

Just one question: Will these patches also work for group swarm and therefore will prevent that these bugs won't occur again once group chat will be enabled by default?

it should

Ok. Thanks for info!

mentioned in issue jami-client-android#663 (closed)

mentioned in issue jami-client-android#1175

mentioned in issue jami-client-qt#1251 (moved)

mentioned in issue jami-client-qt#1546 (moved)