On Windows using MSC, unsigned long is 32 bits even on 64-bit systems, while unsigned long long is 64 bits.

This commit replaces the call to std::stoul with std::stoull which should be portable.

This will address the following Jami-client issue:
jami-client-qt#1419

Change-Id: I9f7998573f493f479b9f97bf5d56ef65b8b58f57

The PUPnP::clearIgds function is called when the UPnP context is
stopped. We don't want to keep receiving and processing IGD events after
that point, so we need to unregister our libupnp "client handle".

GitLab: #29
Change-Id: I017e6ec8aea1423d63381c9e5b3952cff7dfeb2e

GitLab: #21
GitLab: #28
Change-Id: I1c8e0ba00139b516ab964f8e0be76b571bd47534

GitLab: #27
Change-Id: Id3b73839951ef40e99a424148290252a99879a8b

Change-Id: I7b4ee7d3bd2b409ad098515c2a9c61eb67ce0833

Using PJSIP functions without calling pj_init first can lead to subtle
non-deterministic bugs.

GitLab: #18
Change-Id: I9364fd247165c0ce19a8d0d42575fb66651b54a3

Change-Id: I57afba75c41a4f46ec6f97d3ebd2b0a33151cddb

Change-Id: Iec6d57d6a66557a66096c7a8f67e025c6ca5a64c

GitLab: #23
Change-Id: Ife39db96ee554adf547606c5e3a14fc53c13cda9

Change-Id: I5db532611b48916b599d81515a37664a61830d20

Change-Id: I9e6f9cf83d4460bdfefbeb49f91ef162000c1915

Change-Id: I7b69bd74a401aac644ad42a521cfe8a17f455974

this piece of code could run on a spacecraft

Change-Id: I7f47ed35b5d03dc449bd8d9459682f2101c25518

Change-Id: Ic75d07dd85a09af8255e24d5993920d8bf1ed005

François-Simon Fauteux-Chapleau authored 1 year ago and Adrien Béraud committed 1 year ago

GitLab: #19
Change-Id: Id8adf0faca9e575ce035d7e9a1cc5744d92ef635

cinfo->mtx_ MUST be locked before socketsMutex, so it SHOULD never
be locked in a callback. Retrigger the lock in its own thread avoid
a deadlock there.

GitLab: #20
Change-Id: If17af7db81d8ca2b990629446b5d78dc11a785b1

If we're joining and already shutdown, no need to perform complex
code.

GitLab: #19
Change-Id: Ie8bc24361c9e1ab71b26f19711cce928a2b64077

Andreas Traczyk authored 1 year ago and Adrien Béraud committed 1 year ago

https://review.jami.net/c/dhtnet/+/26809 revisited

Change-Id: Ib8e20e6322fd06ca0a2acb25823549e3271ca593

Sébastien Blin authored 1 year ago and Adrien Béraud committed 1 year ago

Else, a deadlock may occurs

jami-daemon#936
Change-Id: Ib4a02845bd0b7e5d482f3fc5f5c8b8a01a50a80f

Change-Id: Ic9bd9a2b570b334cd84652cae97c9a1ffe3350b5

It seems there are scenarios in which the ConnectionInfo is disposed during the on-ready callback, resulting in the TlsSocketEndpoint's callback mutex being locked twice on the same thread.

Change-Id: I401b3c70ba81708e4a3d4ecf3f099f0292c2ff04

Change-Id: Ic24123e329b221f5f1e24d3df6f3cc93649c4591

To check if we're connected with a device

Change-Id: I9d0659c3d6d5e305baabd5c4156a820754bae377

In the else branch, `s` is always an invalid iterator.
Use `us` instead.

Change-Id: Ib517dce22f3bde103f753b325e919f86db299623

Change-Id: Ia0c3c975961bf96c6db80ed8f5c7b45bdee7e9cb

Change-Id: I03cf7bead8bcf5760d035e32a82ec3412ef6fea9

Change-Id: Ie1338675efb16783a68a344da2a164632c0e088a

Change-Id: I869fcb8903654558c39afa4f9d4aaefecd7cb40a

Change-Id: Ifdb26180460343fab1cf39a770d90d924f8ef263

Adrien Béraud authored 1 year ago and Sébastien Blin committed 1 year ago

Change-Id: I4c29a9117414da46bc57af6649763cecea6e6918

Adrien Béraud authored 1 year ago and Sébastien Blin committed 1 year ago

Change-Id: Ie5fe090494e30f99587d048dad709b8ac50a3cef

Change-Id: I46a4563e24f3a427931be886b726a585fe823eff

Change-Id: I8ef7ed0336a02692fb3ec0959f2f7f8891c52808

If a TLS handshake was failing, the device information was not
correctly removed, causing a connection to be detected and further
communications to fail.
So, while monitoring, some connections were stuck in "Connecting TLS".

Moreover, remove waitForReady because it's unused

Change-Id: I8350d7f8731311ab46db78fb26328edc0dcb31dc

Avoids blocking on socket write sequentially,
and prevents locking while blocked on a write.

Change-Id: Ia9e6e0f3e0d73e070f90d988f351d782932a1a07

Change-Id: I93782be5cd93c824d14e7c9871be47ed6527d836

Change-Id: I44eca33dc35747eda86cee32be38782cb96d077b

Avoids potential processing ordering issues

Change-Id: I480872ffecb80439620a8442610b845f790b9db6

Allows to better handle new states in the future.

Change-Id: Ie8b28f9776d2c4ce8a45eb02f5af323a2ea37ffd

Change-Id: I71d88e0efbf78009ba003b03d107c0f897dbc485