GitLab: #1101
Change-Id: Ifaee9fe0a2b79716e00ccc1a12c8c78c348e80bf

Adrien Béraud authored 1 month ago and François-Simon Fauteux-Chapleau committed 1 month ago

GitLab: #1104
Change-Id: I8d5c0a1fdb2f9bfc84f442e1323216ae3100da6d

Given the change made in commit
e048f1b9, it no longer makes sense to
use a null pointer as the default value for the optHistory argument of
the addToHistory function.

GitLab: #1102
Change-Id: Ifc5ca8b069c16d7d9cca2cbc0c8237c56895ff4e

Change-Id: Icd57e9a33b58c97ef9df18531510fb9590a9ee73

Change-Id: I68f4aab6d1588a53aaaf5757cb9dc20b8e6d8b8d

GitLab: #1100
Change-Id: I22255a2b34e5c33d1db4c1a02747874512372d5b

remove artificial const signature for announce and addToHistory

Change-Id: I2edbffeaaaff4bbfa68122fa96ed23aa8859dc0b

Change-Id: I178b437e99cf31c13622df136d635ff2147a04a9

Adrien Béraud authored 1 month ago and Adrien Béraud committed 1 month ago

Prevents multiple requests to JAMS for every message sent.

Change-Id: I17a0e9b885730979b10c635dd99ac3d37bef69bd

Change-Id: Idaf8e45775d2b76a9b306563baa074c7484ff68c

Change-Id: Ia92378315f88051de76311d23156c1eb85c07770

Change-Id: I527d834dac6fb2f57c879d02afd09c529f95b5fe

Adrien Béraud authored 2 months ago and Adrien Béraud committed 2 months ago

Change-Id: I1aa416e952c2b38107c6534e104601641fabbf5f

Adrien Béraud authored 2 months ago and Adrien Béraud committed 2 months ago

Change-Id: I8f11b6ede9701ba7770c7c774e87b6028dda117b

Adrien Béraud authored 2 months ago and Adrien Béraud committed 2 months ago

GitLab: #1097
Change-Id: I742d1306007b3ae4908ee2d46bd5275d1ce2c99a

Léopold Chappuis authored 2 months ago and Adrien Béraud committed 2 months ago

resolved a segfault triggered by multiple clients accessing and calling clearCache simultaneously during conversation loading.

Change-Id: Ic2b134d67d1a207f45e52c5aedeee5712ead14ba

This patch removes the callback argument to the doUnregister function,
which wasn't really needed since it was always called right before
returning from the function.

The patch also removes all calls to the shutdownConnections function
outside of doUnregister, and instead adds a boolean argument to
doUnregister to allow the caller to specify if they want the connections
to be shut down. This is a preparatory step for fixing the bug described
in the GitLab issue linked below.

GitLab: #1095
Change-Id: Ic78659f2e00684fd1db91c0ee3cf894a53d558ce

Change-Id: I8b66fe04a4ed5b1aa14da99cde3b7c84d1361e2d

GitLab: #1093
Change-Id: Iaaed6d86dba597b7b4435a98022aad163599c9fb

Adrien Béraud authored 2 months ago and Adrien Béraud committed 2 months ago

Change-Id: Ia2858d7dab79954312b657ea4380f0ea65bfa640

Adrien Béraud authored 2 months ago and Adrien Béraud committed 2 months ago

Change-Id: Ia3ec3a96660821175d52c0120642c7c6fc946d1c

Change-Id: I2753c58c12d167ee5f7454e5a2ed893991c90e24

Change-Id: I16c4b8ebea5a534fa1b25baaf029c62c6e7b8f84

Change-Id: I019a385b43d78ce35691dd0da3599749e0442c83

Adrien Béraud authored 3 months ago and Adrien Béraud committed 3 months ago

Change-Id: I2655eb16f9a6e6cbee6bdb8ae620ec3102cf0c94

Change-Id: I6b84270da276a91ea6f455ad477e73d04e601ea5

Sentence case
…
→
DHT
higher → greater than
ID
libgit2
PJSIP
SIP
try on → attempt with
vCard

Change-Id: Iaeca39f1b8daaad71452dfb595b61e4fb7e8204e

Léopold Chappuis authored 3 months ago and Adrien Béraud committed 3 months ago

The marker used to indicate that the desired message had been passed was wrapped in a conditional statement that could evaluate to false when it needed to set the marker to true. This prevented the function from recognizing that the desired message had already been processed.

Change-Id: I9934858f5837d91fc5dfc54debb417dd8c19c933

The Conversation::loadMessages2 function uses the information cached in
both loadedHistory_ and memberToStatus, so it's important for the two to
always remain consistent with each other. This patch fixes two issues
that could cause them to diverge:

1) the Conversation::clearCache function currently resets
   loadedHistory_, but not memberToStatus;

2) Conversation::Impl::loadMessage2 doesn't modify loadedHistory_ but
   sometimes resets memberToStatus.

GitLab: #1087
Change-Id: I21caedea996d5ad66b695a0f130cd473c5d5ddc4

ovari authored 4 months ago and Adrien Béraud committed 4 months ago

cannot → unable to
fail to → failed to
{inexistent, non-existing} → nonexistent
P2P
try → attempt
UPnP
retrieven → retrieved
testAdminCannotKickTheirself → testAdminCannotKickThemselves
wishes → wants

Change-Id: I84dbb7b78fd674507eab7186c8f9e0a5f1d3d5b3

François-Simon Fauteux-Chapleau authored 4 months ago and Adrien Béraud committed 4 months ago

GitLab: #1083
Change-Id: If43a74758bbceff69e57baa2fc70c4526ec1f9f0

ice → ICE
pnp → PnP
rtp → RTP
try → attempt
un-hold → unhold
won't → unable to

Change-Id: I5a012dd22b40027a9470b42fb7ae0b512619c8ee
GitLab: jami-client-qt#1730

Change-Id: I7d7f2050b8af62e277a57e117b25db2707596404

GitLab: jami-client-qt#1888

Change-Id: Ic6a677189b1ce5b2859db7e9f5b889e236da7a85

Change-Id: Iae76467110d02fef007e075103d1a79b0aa031b2

GitLab: #1081
Change-Id: I3ac3468e8ff5b41250a76ab7f40b6ca0e7331f09

This fixes a bug where JamiAccount::sendMessage would sometimes call
MessageEngine::onMessageSent with the `ok` argument set to false even
though the message had actually been sent successfully.

GitLab: #1081
Change-Id: I51190994b81e9e897dec546fd254d6e0ca4c99d3

3-character ellipsis ... → 1-character ellipsis …
smart quote ’
infos → info
Setupping → Setting up
try → attempt

Change-Id: I97ed89b9e9b1193162c856b4bb143f6bab55666b
GitLab: jami-client-qt#1730

Adrien Béraud authored 4 months ago and Adrien Béraud committed 4 months ago

Change-Id: I468078f507c6156b2d4d45a7abb54dbdc1571da9

Adrien Béraud authored 4 months ago and Adrien Béraud committed 4 months ago

Change-Id: Iba8066ea8131e458264b14ba46f16bdd0091ab91