Ming Rui Zhang authored 3 years ago and Sébastien Blin committed 3 years ago

Use on_rx_reinvite to send re-INVITE response manually

Gitlab: #499

Change-Id: Ia6127f84933708786441f08e26ae4038f41026bc

Kateryna Kostiuk authored 3 years ago and Kateryna Kostiuk committed 3 years ago

This reverts commit 8a1c2b65.
libtasn1 build fixed in https://review.jami.net/c/ring-daemon/+/17429

Change-Id: I6bf7becb34402cea5f8351bf813a0cd74b7a79f8

Pierre Lespagnol authored 4 years ago and Sébastien Blin committed 3 years ago

Fix the audio/video message playback

Gitlab: #489
Change-Id: Idce7cbe45fb05622c94ba54187e2477eb93168de

Adrien Béraud authored 5 years ago and Sébastien Blin committed 3 years ago

Change-Id: Id983f360bff9f6732e37090934f43bd247f0bb9e

Change-Id: I3710414acdff1eef447e308d6ae3827e27add04b

This will give the possibility to merge two states of the conversation.

Change-Id: I1dfcbc2d9bd581c0b41a0f01919f490d4cc20d13

This patch introduces ConversationRepository::log(last, n) to get the commits
from [last-n, last], where last (if not specified) is current HEAD.

Change-Id: Ia6b8eb96b8a4a0de3614d4e422c1179f976d2ab0

Retrieving a conversation is done by cloning the distant repository

Change-Id: Ib68749d0cd37ff708b08187e987cc3fdeaa0fbe6

This patch offers an API to create conversation. A conversation
is represented by a git repository.

The repository will contains the account certificate in /admins,
its CRLs in /CRLs and the device key in /devices. Moreover,
the first signed commit's hash will be the conversation's id

Change-Id: Iac7ff7f6002185a5bb0f51d4c10df1afe9e059b4

Needed by the swarm chat in the future

Change-Id: Ic5802a0de8091c12b6f5ed666ee488c620723149

Change-Id: I4ede33afd5823eb3ce320a03be10e79fcb417ae8

fixed by https://review.jami.net/c/ring-client-android/+/17432

Change-Id: I8898d58457c42fc8217328d657ddaff4b97ae9cb

Change-Id: I7a2227aafe585bee1f4ed115f22e987e77fd49ff

Maxim Cournoyer authored 4 years ago and Adrien Béraud committed 3 years ago

Bring consistency in the indentation rules used throughout the file.

GitLab: #487
Change-Id: I4d8e4050a0f21df9a380fc25e0d3de04f15fe941

Maxim Cournoyer authored 4 years ago and Adrien Béraud committed 3 years ago

The CFLAGS, CXXFLAGS, LDFLAGS and other variables intended to be
overridden by the user should not directly be set by the package.
This change uses one of the approaches recommended by the Autoconf and
Automake manuals, which is to use custom variables to accumulate flags
in the configure script and add them to the make targets they apply
to.  This has the benefit of not cluttering the flags used during the
Autoconf tests, which has proved problematic (see the previous commit
for a demonstration).

* configure.ac: Replace CFLAGS, CXXFLAGS, CPPFLAGS and LDFLAGS by
DAEMONCFLAGS, DAEMONCXXFLAGS, DAEMONCPPFLAGS and DAEMONLDFLAGS,
respectively.
Use these custom variables as the default values of AM_CFLAGS,
AM_CXXFLAGS, AM_CPPFLAGS and AM_LDFLAGS, respectively.  Remove an
extraneous check on jsoncpp.
* bin/Makefile.am (ringcli_CXXFLAGS): Honor the the AM_CXXFLAGS variable.
globals.mk: Extend rather than override the AM_CPPFLAGS variable.
* src/Makefile.am (libring_la_LDFLAGS): Honor AM_LDFLAGS.
(libring_la_CFLAGS): Honor AM_CFLAGS.
(libring_la_CXXFLAGS): Honor AM_CXXFLAGS.
* src/client/Makefile.am (libclient_la_CXXFLAGS): Honor AM_CXXFLAGS.
* src/im/Makefile.am (libim_la_CXXFLAGS): Remove variable.
* src/jamidht/Makefile.am (libringacc_la_CXXFLAGS): Likewise.
* src/media/audio/Makefile.am (libaudio_la_CXXFLAGS): Honor
AM_CXXFLAGS.
(libaudio_la_LDFLAGS): Honor the AM_CXXFLAGS variable.
* src/media/audio/coreaudio/Makefile.am (libcoreaudiolayer_la_CXXFLAGS):
Likewise.
* src/media/video/Makefile.am (libvideo_la_CFLAGS): Honor the
AM_CFLAGS variable.
(libvideo_la_CXXFLAGS): Honor the AM_CXXFLAGS variable.
* src/media/video/v4l2/Makefile.am (AM_CXXFLAGS): Extend rather than
override.
* src/plugin/Makefile.am (libplugin_la_CXXFLAGS): Honor the
AM_CXXFLAGS variable.
* src/security/Makefile.am (libsecurity_la_CXXFLAGS): Likewise.
* src/sip/Makefile.am (libsiplink_la_CXXFLAGS): Likewise.
* src/upnp/Makefile.am (libupnpcontrol_la_CXXFLAGS): Remove variable.
* src/upnp/protocol/Makefile.am (libupnpprotocol_la_CXXFLAGS): Likewise.
* src/upnp/protocol/natpmp/Makefile.am (libnat_pmp_la_CXXFLAGS): Likewise.
* src/upnp/protocol/pupnp/Makefile.am (libpupnp_la_CXXFLAGS): Likewise.
* test/sip/Makefile.am (AM_CXXFLAGS, AM_LDFLAGS): Extend rather than override.
* test/unitTest/Makefile.am (AM_CXXFLAGS, AM_LDFLAGS): Likewise.

GitLab: #487
Change-Id: I18be9d812159f8156efb9f7849e7eac6d4c6b3ca

squash! configure.ac: Do not set user variables.

Change-Id: I1146ea15d6fb75fe53d3cbdd782e981c933e82a6

Maxim Cournoyer authored 4 years ago and Adrien Béraud committed 3 years ago

Do not unnecessarily clutter CPPFLAGS; the variable is honored by
Autoconf while running its conftests and can cause issues such as
symbol clashes between the libnatpmp and webrtc-audio-processing
library observed below:

configure:20851: checking for initnatpmp in -lnatpmp
configure:20873: g++ -std=gnu++17 -o conftest  -DNDEBUG=1 -O3 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -DPJ_AUTOCONF=1  -I/home/maxim/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/include  -fvisibility=hidden -DDRING_BUILD  -Ddring_EXPORTS  -DASIO_STANDALONE -I/home/maxim/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/include -I/gnu/store/zimpk6gqmjrwxc7fnam212kv3a6dwpzz-jsoncpp-1.9.2/include -DWEBRTC_AUDIO_PROCESSING_ONLY_BUILD -DWEBRTC_POSIX -I/home/maxim/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/include/webrtc_audio_processing  -Wl,-Bsymbolic -ldl -L/home/maxim/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/lib -L/gnu/store/zimpk6gqmjrwxc7fnam212kv3a6dwpzz-jsoncpp-1.9.2/lib -ljsoncpp -L/home/maxim/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/lib -lwebrtc_audio_processing conftest.cpp -lnatpmp -lpthread  -lssl -lcrypto >&5
ld: /tmp/cc5prP4w.o: in function `main':
conftest.cpp:(.text.startup+0x0): multiple definition of `main'; /home/maxim/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/lib/libwebrtc_audio_processing.a(libwebrtc_audio_processing_la-click_annotate.o):click_annotate.cc:(.text.startup+0x0): first defined here
collect2: error: ld returned 1 exit status
configure:20873: $? = 1

This was causing the link test of the libnatpmp library to fail,
which in turned caused the natpmp support to be disabled entirely.

* src/Makefile.am (libring_la_LDFLAGS): Add @WEBRTC_LIBS@.
(libring_la_CFLAGS): Add @WEBRTC_CFLAGS@.
* src/media/audio/Makefile.am (libaudio_la_CXXFLAGS)
[HAVE_WEBRTC_AP]: Add @WEBRTC_CFLAGS@.
* src/media/audio/echo-cancel/Makefile.am
(libecho_cancel_la_CXXFLAGS): Add @WEBRTC_CFLAGS@ and honor AM_CXXFLAGS.

GitLab: #487
Change-Id: I064d6a563318b34b2f3f516ca2aa8c2831205b09

Andreas Traczyk authored 4 years ago and Adrien Béraud committed 3 years ago

Same as was done in commit: d7a83d24

Change-Id: If55c67037dbf578c1eccc594676b50ae1ad6f876

Maxim Cournoyer authored 4 years ago and Adrien Béraud committed 3 years ago

* configure.ac: Bump required autoconf version to 2.69 and remove the
uses of the obsoleted AC_HEADER_STDC and AC_HEADER_TIME macros.

GitLab: #487
Change-Id: Idb210870c298b83ddabe189e341d0846f04a1bb9

Previously, the build machine would need to provide dbusxx-xml2cpp
itself, while the library would be used from the contribs (always
forced, as dbusxx-xml2cpp is unmaintained and slightly broken on newer
GCCs).  This change removes the requirement to have the dbus-c++
package installed on the build machine.

Change-Id: I25ad2ee3e80afc33b320de9256b724a3c254f4fb

Maxim Cournoyer authored 4 years ago and Adrien Béraud committed 3 years ago

Otherwise the '-lm' linker flag would not be used and compilation the
opus configure time check would fail like (excerpt from config.log):

    pkg-config --exists --print-errors opus
    check_func_headers opus_multistream.h opus_multistream_decoder_create -I/home/mcournoyer/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/include/opus -L/home/mcournoyer/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/lib -lopus
    test_ld cc -I/home/mcournoyer/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/include/opus -L/home/mcournoyer/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/lib -lopus
    test_cc -I/home/mcournoyer/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/include/opus -L/home/mcournoyer/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/lib
    BEGIN /tmp/ffconf.Ad6jtRUj/test.c
        1	#include <opus_multistream.h>
        2	#include <stdint.h>
        3	long check_opus_multistream_decoder_create(void) { return (long) opus_multistream_decoder_create; }
        4	int main(void) { int ret = 0;
        5	 ret |= ((intptr_t)check_opus_multistream_decoder_create) & 0xFFFF;
        6	return ret; }
    END /tmp/ffconf.Ad6jtRUj/test.c
    gcc -I/home/mcournoyer/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/include -fPIC -D_ISOC99_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_POSIX_C_SOURCE=200112 -D_XOPEN_SOURCE=600 -DPIC -I/home/mcournoyer/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/include -DNDEBUG=1 -O3 -fPIC -I/home/mcournoyer/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/include -DNDEBUG=1 -O3 -std=c11 -fomit-frame-pointer -fPIC -I/include -pthread -I/home/mcournoyer/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/include -I/home/mcournoyer/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/include/opus -L/home/mcournoyer/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/lib -c -o /tmp/ffconf.Ad6jtRUj/test.o /tmp/ffconf.Ad6jtRUj/test.c
    gcc -L/home/mcournoyer/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/lib -L/home/mcournoyer/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/lib -Wl,--as-needed -Wl,-z,noexecstack -I/home/mcournoyer/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/include/opus -L/home/mcournoyer/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/lib -o /tmp/ffconf.Ad6jtRUj/test /tmp/ffconf.Ad6jtRUj/test.o -lopus
    ld: /home/mcournoyer/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/lib/libopus.a(celt_decoder.o): in function `celt_decode_lost':
    celt_decoder.c:(.text+0x20d0): undefined reference to `sqrtf'
    ld: celt_decoder.c:(.text+0x20f5): undefined reference to `sqrtf'
    ld: /home/mcournoyer/src/ring-project/daemon/contrib/x86_64-unknown-linux-gnu/lib/libopus.a(bands.o): in function `compute_theta':
    bands.c:(.text+0xe87): undefined reference to `sqrtf'
    ld: bands.c:(.text+0x1178): undefined reference to `sqrtf'

The problem likely was discovered because using a subset of the
required dependencies that didn't pull the math library.

Change-Id: I79bc4f79eaa2288bf20528cd770f1ddafd56dec3

Adrien Béraud authored 4 years ago and Sébastien Blin committed 3 years ago

Change-Id: I2ea856c183df317eab45a5d6d5533ef1b3b6a0df

Change-Id: I2daba297b06c7886d29ba613a6341de33ad7fa86

Change-Id: Iabc63814f515d53f1de8fc539ba49e154843a1cd

IceTransport desctruction shouldn't block on the main thread.
This problem is noticable when calling refuseCall from the UI
thread and results in a blockage lasting MAX_DESTRUCTION_TIMEOUT.
Even if MAX_DESTRUCTION_TIMEOUT is not reached, a polling interval
of 500ms requires this destruction be done async.

Change-Id: Ib6f9c0cff155755de30966875ab76e7288d39405

Vladimir Stoiakin authored 4 years ago and Sébastien Blin committed 4 years ago

Change-Id: I69cc9da36dfbb1258f8f84e9351a6c1c29c2a722

Change-Id: I81b8d9988aaa79d6e67142417e9f004689d69ab9

Kateryna Kostiuk authored 4 years ago and Kateryna Kostiuk committed 4 years ago

When we stop playback stream we should check current audio category.
If it is AVAudioSessionCategoryPlayAndRecord it is means we also have
capture stream running and we should not destroy it.

Change-Id: I4cc0f2ddcd8b26840f4b2968a890c4803c187448

Also adds portaudio api specific device preferences in the config
using strings instead of indices. An empty string will cause the
default communication device to selected.

Change-Id: I64597c2d706acdd6e1422558d7609fc14a7ad818
Gitlab: #463

Ming Rui Zhang authored 4 years ago and Adrien Béraud committed 4 years ago

GitLab: #478

Change-Id: I4aed6f7b171a2194fd0070c5510ca1660adb6204

This reverts commit 6cfe9432.

Reason for revert: causes reference to temporary

Change-Id: I2ff3e94c490ee1f17d3e96486d4a1aa5732d684f

Adrien Béraud authored 4 years ago and Sébastien Blin committed 4 years ago

Change-Id: If1b647a76303362ae0240a0e11505502260b5c8d

Sébastien Blin authored 4 years ago and Adrien Béraud committed 4 years ago

Change-Id: Iedcfe91af40893004c8f640c8a718966db8d7468

Pierre Lespagnol authored 4 years ago and Adrien Béraud committed 4 years ago

Gitlab: #465
Change-Id: Ib86573e5c0e186253c51624b38b9951d77f1a1fa

Change-Id: Ica016084fb36c3f4110fe4fe3281e43d29c65275

Change-Id: I155f5182fbb370116e020151dc3c154cee66c814
GitLab: #407

like SIPCall::onMediaUpdate, we should not restart medias if
the call is ended or a crash will typically happen with multi-device
where first device answer and hangup during the negotiation with
the other.

Change-Id: Ib6bd2a316c8f03ace25926fd20338d72613d0c54

Adrien Béraud authored 4 years ago and Sébastien Blin committed 4 years ago

Change-Id: Id2d03ca3d645d7178019bf05c1951c6a78019095

Adrien Béraud authored 4 years ago and Sébastien Blin committed 4 years ago

Change-Id: I9273985b6c6156e6e5a39388cdf32ed48fccd58d

Mohamed Chibani authored 4 years ago and Sébastien Blin committed 4 years ago

In AudioRtpSession, when a new AudioInput instance is created, its mute state
is always set to default (un-muted) even if the AudioRtpSession is in mute
state.
Fixed by applying the mute state when a new AudioInput instance is created.

Gitlab: #482

Change-Id: I3f7e92cfcfd63bc5c6318f317e7fa96fe5f17a7c

Mohamed Chibani authored 4 years ago and Sébastien Blin committed 4 years ago

SipVoipLink may never be intialized in Manager instance (Manager::init())
leading to a crash when the Manager calls finish(). Added a check
to prevent the crash.

Gitlab: #481

Change-Id: I817a7795ce4341e6214a44e46037b0183fde53c5