On Windows using MSC, unsigned long is 32 bits even on 64-bit systems, while unsigned long long is 64 bits.

This commit replaces the call to std::stoul with std::stoull which should be portable.

This will address the following Jami-client issue:
jami-client-qt#1419

Change-Id: I9f7998573f493f479b9f97bf5d56ef65b8b58f57

Change-Id: Iec6d57d6a66557a66096c7a8f67e025c6ca5a64c

Change-Id: I7b69bd74a401aac644ad42a521cfe8a17f455974

this piece of code could run on a spacecraft

Change-Id: I7f47ed35b5d03dc449bd8d9459682f2101c25518

cinfo->mtx_ MUST be locked before socketsMutex, so it SHOULD never
be locked in a callback. Retrigger the lock in its own thread avoid
a deadlock there.

GitLab: #20
Change-Id: If17af7db81d8ca2b990629446b5d78dc11a785b1

Andreas Traczyk authored 1 year ago and Adrien Béraud committed 1 year ago

https://review.jami.net/c/dhtnet/+/26809 revisited

Change-Id: Ib8e20e6322fd06ca0a2acb25823549e3271ca593

It seems there are scenarios in which the ConnectionInfo is disposed during the on-ready callback, resulting in the TlsSocketEndpoint's callback mutex being locked twice on the same thread.

Change-Id: I401b3c70ba81708e4a3d4ecf3f099f0292c2ff04

Change-Id: Ic24123e329b221f5f1e24d3df6f3cc93649c4591

To check if we're connected with a device

Change-Id: I9d0659c3d6d5e305baabd5c4156a820754bae377

Change-Id: I03cf7bead8bcf5760d035e32a82ec3412ef6fea9

Change-Id: Ifdb26180460343fab1cf39a770d90d924f8ef263

If a TLS handshake was failing, the device information was not
correctly removed, causing a connection to be detected and further
communications to fail.
So, while monitoring, some connections were stuck in "Connecting TLS".

Moreover, remove waitForReady because it's unused

Change-Id: I8350d7f8731311ab46db78fb26328edc0dcb31dc

Avoids blocking on socket write sequentially,
and prevents locking while blocked on a write.

Change-Id: Ia9e6e0f3e0d73e070f90d988f351d782932a1a07

Change-Id: I93782be5cd93c824d14e7c9871be47ed6527d836

Change-Id: I71d88e0efbf78009ba003b03d107c0f897dbc485

Change-Id: I5bc6cdc830959dfc37f2b0f620340653ed2342a9

* merge info, waiting and pending maps into DeviceInfo,
  improving consistency of various operations
* DeviceInfo has its own mutex,
  and operations keep a weak pointer to it,
  reducing contention
* DeviceInfoSet encapsulate atomic management of DeviceInfos,
  enforcing proper locking order

Change-Id: I12c107782600355a34d460e7802d92ae9d590993

dht() can live longer, so technically there is nothing preventing
this to be nullptr there

Change-Id: Ifc77f1a9c8e3b3d889da16056a7e8965ec4786ed

Change-Id: I182ba3b7e9a69ef7fd02808cfa36576473f8857d

Change-Id: I55ea604cc2542fb0d38b465cfa6a090450fe9322

Change-Id: Ie56f065a58b9a5453d3b2df86cd7a7b249fac077

Change-Id: I96eb3ed8d0d4f82adb28c8d47a5751bc3f603560

Change-Id: I6a5d7b458f033f0d3dfebefb29bc7a097720e701

Change-Id: I1c532f150cc47440d41583a1806a32569b1f21af

Change-Id: I1c872351cf3f0e519595ab8d734db2841d7d2218

Change-Id: I2c3a9f626ca56d63c239f2afc5d9ed71db6f631d

Amna Snene authored 1 year ago and Adrien Béraud committed 1 year ago

Change-Id: I3fd0e040aaeb80cda41f719bc4b9e27279c37663

Change-Id: Iecf54a3a0368c99705969679fe18ceda59ce4290

Change-Id: I5408d193bda6830395bd705371c86c949643ee74

Change-Id: I27cf22e66a4c86742b022136d036ca77c25dc724

Change-Id: I2948cb86e4655471d6809ddb0971de60d3950948

Change-Id: I8abe918b0e7405cff7df59c7d7f29479b270218a

Change-Id: I2fe4f7e2c48edb99154d07619a79dae3bff6b091

Change-Id: Id006a25ebd5501d143ef7ee1f39008fb1d7cd87e

Amna Snene authored 1 year ago and Adrien Béraud committed 1 year ago

Change-Id: I20a08723ae90cb8daf1b35bf7cbbea44ef067dca

Amna Snene authored 1 year ago and Adrien Béraud committed 1 year ago

Change-Id: If63c8121351f81b869b5b48b3df64eb412dd6f79

Change-Id: I9d982eb3a543f9fb6c38b0321b757947ccf3de08

ice_transport: fix log

Change-Id: I55177a814cfc28db594229652c5c9c2f849d85f1

This reverts commit 62b657d7.

Change-Id: I1789883b516f96f6c5ffc664da6f940c3dcd3e61

Change-Id: I10999a2126a6ee0ed1fbc0d9edcef963a6e6c261