This patch removes the callback argument to the doUnregister function,
which wasn't really needed since it was always called right before
returning from the function.

The patch also removes all calls to the shutdownConnections function
outside of doUnregister, and instead adds a boolean argument to
doUnregister to allow the caller to specify if they want the connections
to be shut down. This is a preparatory step for fixing the bug described
in the GitLab issue linked below.

GitLab: #1095
Change-Id: Ic78659f2e00684fd1db91c0ee3cf894a53d558ce

Adrien Béraud authored 3 months ago and Adrien Béraud committed 3 months ago

Change-Id: Ia3ec3a96660821175d52c0120642c7c6fc946d1c

Change-Id: I2753c58c12d167ee5f7454e5a2ed893991c90e24

Improve code clarity only. No logic changes.

Change-Id: I348185c79bf48248f1f407627d12fc50cbe3e1d4

Change-Id: I585ba37ea176173facfde6bea4282b42d9c00eb0

ovari authored 3 months ago and Adrien Béraud committed 3 months ago

Change-Id: I194497974f46f88d0b16c41391d45797fecc6943

Change-Id: Ibc45eb6228732b8163a6dd29b0bfbd2cc5cfaa46

Change-Id: I6b84270da276a91ea6f455ad477e73d04e601ea5

…
→

Change-Id: I3421a0b8b9528a6815da6b826a1ca1b066b9b73f

ovari authored 4 months ago and Adrien Béraud committed 4 months ago

cannot → unable to
fail to → failed to
{inexistent, non-existing} → nonexistent
P2P
try → attempt
UPnP
retrieven → retrieved
testAdminCannotKickTheirself → testAdminCannotKickThemselves
wishes → wants

Change-Id: I84dbb7b78fd674507eab7186c8f9e0a5f1d3d5b3

The SIP accounts were not functioning properly because they weren't notified that a new profile vCard was available. Since they lack a URI, the accountId needs to be included in the URI. This adjustment shouldn't cause significant issues, as accountIds have a different format than URIs.

Change-Id: I2fd41909c4bf20a9c42538620dacc732b6ab27e1

ice → ICE
pnp → PnP
rtp → RTP
try → attempt
un-hold → unhold
won't → unable to

Change-Id: I5a012dd22b40027a9470b42fb7ae0b512619c8ee
GitLab: jami-client-qt#1730

Léopold Chappuis authored 4 months ago and Adrien Béraud committed 4 months ago

To enhance the flexibility and scalability of this API, we can include the filetype parameter.

Change-Id: I0fcb69a1073ac2cb4576d7a701e5339c1c5db5de

Léopold Chappuis authored 4 months ago and Léopold Chappuis committed 4 months ago

If another key includes "PHOTO" during the API update process, it must be removed.

Change-Id: Ic338263ec3966556c61e12752ccea91fb730b794

Change-Id: Ia844cbac3ffb529d5ee55c0c589c94a06e37fb73

Léopold Chappuis authored 5 months ago and Adrien Béraud committed 4 months ago

Modified behavior to support cases where a SIP account uploads a new profile. The main idea is to move the vCard management logic in the daemon.

Change-Id: I74dece22cd2917ad2f5ff2b37e2d413696cdcec3

Change-Id: I8b9e25f99da5945684e265d3923b74065c8ef8eb

ovari authored 7 months ago and ovari committed 7 months ago

8+3 filename → 8.3 filename
be ware → beware
{cannot, can not, cant, can't, could not, couldn't} → unable to
conpleted → completed
file name → filename
imcomplete → incomplete
informations → information
trying to → attempting to
wrong password → incorrect password

GitLab: jami-client-qt#1730

Change-Id: Ia7757efafd2c06af978db02c65b40b1b77c393f8

Change-Id: I55a6c72a0abe0cdc55639064157884f383e25e7b

+ Unbind call from default layer and let the conference manages
the binding to the default ringbufferpool
+ Avoid to bind on receive, upper layers must bind the audio

GitLab: #959
Change-Id: I639e34281668c4d49ff695fa3e38a1896f567f07

GitLab: #958
Change-Id: I91036c9f1e20ee19e3896eb8e0110aa36a9d0602

Also, start to fix audio binding (this will be a full patch, but
at least do not attach host)

GitLab: #959
Change-Id: I0aeb9121e2880a5afb4b1ca1a30710d1b60a2e7e

GitLab: #978
Change-Id: I89644008fd6e8b22e1a1805778f3983ab9df7795

Change-Id: I0aacf47c70a0de4fcd1a68f6688cf0ee0c551934

Now, a client should not do any logic and not store preferences
client side.
+ When a member is removed while banned, the typing indication
is updated
+ Timeout is computed both for sender and receiver
+ Sending and receiving a composing status is managed by the
account's config.

GitLab: #951
Change-Id: Iba9441736eec4f71695bfbd609d4b9e8b6adcb73

Change-Id: Ie52a0f0c0b499d22caa03714741e9bca96839fac

Sébastien Blin authored 1 year ago and Adrien Béraud committed 1 year ago

This allow unit test to be able to check why a call is declined and
allow client to clarify messages for call messages

Change-Id: I37f8f1d1160910ca702010e4a9a40c9ecbcd13fd

Change-Id: I30e0a693dcaa3e88df579b6e794be9b2de9b147c

The goal of this patch is to allow the clients to get a better
sent/read status from the daemon.

API doesn't change much, but internal logic got some changes. For the
client:
+ SwarmMessage now contains a map<string,int> status where string is the
  uri of a member, int is the status (0 = sending, 1 = sent, 2 = read)
+ cancelMessage is removed as not used anymore (sendMessage with flag=1
  will edit a message)
+ getMessageStatus is removed as the status is sent in the SwarmMessage
+ accountMessageStatusChanged is now emitted for swarm messages when a
  fetch or setDisplay occurs. Client must handle this signal correctly.
+ Previous code to manage last displayed, fetched status is now merged
  with message status
+ Sync info is done when the sync is opened, else status are not updated
  correctly

GitLab: #948
Change-Id: I60763d4de8a995c6fc9f6df6434e266211f8dc2f

URI was illformed, scheme is intended. Now it works for both
jami and sip accounts

GitLab: #947
Change-Id: Ifc8d88be1cec91428dd8060c3c4e12efc55243f0

Change-Id: I263e3057efb3aef103b3de367d9f2d0e03d5b368

Not needed in c++17

Change-Id: Icf3c7b7781dbf829db2770a750cf10ec8fbeef45

Sébastien Blin authored 1 year ago and Adrien Béraud committed 1 year ago

Change-Id: I829473d42b2b90f26ed2d93bbde063a21ce0952c

Change-Id: I344c6aa24aad4d0763d8b9dedab100467832920f

Change-Id: I8502119ce7ff540275c9a273b6896cbbedaf9cbb

This patch executes handleMediaChangeRequest on a thread pool
to avoid potential deadlocks. Since handleMediaChangeRequest
locks callMutex, it could cause a deadlock if sendSIPInfo is called
at the same time.

GitLab: #915

Change-Id: I7e79eef0dd00f2814ba360fc8a6e96ff107285c8

Aline Gondim Santos authored 1 year ago and Sébastien Blin committed 1 year ago

GitLab: #485
Change-Id: I0ae7c23da2a1f2384699639cc0de58f8f05b33ec

Aline Gondim Santos authored 1 year ago and Sébastien Blin committed 1 year ago

GitLab: #485
Change-Id: Ie3f129cd0cee14a97764eb22ee2b5f530a3f3023

GitLab: #910
Change-Id: I5e70fca251678f4355f1ea4925aec6e66b04e5c7

Else stopping while a rtp success come (cf ut_recorder) triggers
a deadlock.

Change-Id: I8d64cfb5f5edd8cb40cca847a252e2f24d851ce8