Sébastien Blin authored 4 years ago and Adrien Béraud committed 4 years ago

Because all file transfers are down through channeled sockets,
cancelIce_ is not used anymore and a file is cancelled when
the linked channel is down.

Change-Id: Icbb075149ea61660bee0a9013b5cd87bc0eb2463

Adrien Béraud authored 4 years ago and Sébastien Blin committed 4 years ago

Change-Id: If44dea4f9f1bf31ccb7237dca29c42735ecce5a8

Sébastien Blin authored 4 years ago and Adrien Béraud committed 4 years ago

Also makes ftp server non blocking

Change-Id: I26a3804a04c61274c064662d678b65747ff8ddc9

Sébastien Blin authored 4 years ago and Adrien Béraud committed 4 years ago

This breaks support with old versions from <=2019

Change-Id: Ie56e3db19dd73dfd7668c373caaeaac60e708c9c

add a onStateChange callback to delete channeled structures on finished states.

Change-Id: I7670cc655719029806a7a887d48197dc2f488651

Sébastien Blin authored 4 years ago and Adrien Béraud committed 4 years ago

Some clients can try to get the data info in the DataTransferEvent's callback
this can provide a deadlock on infoMutex_. To prevent that, emitting the signal
on the main thread is necessary.

Change-Id: Ifca032e497272c3da9e2a866a23e4883a142d1e9

Change-Id: I2dd97518218a5a777ddde2ce8d23e2d5dde4dcf0

Sébastien Blin authored 4 years ago and Andreas Traczyk committed 4 years ago

Change-Id: I193328586ea401c16d64393eb0dfb2ebb0d80e9d

And some clean

Change-Id: I0e7a607b1749e608f0911f37065a0695df2d45b5

Because of the ConnectionManager, the daemon is now able to send
direct messages such as typing indications and read status. This
can be also used to move current features and improve it.

This patch is a first step to improve vCard syncing. The idea is
to send the vCard directly when a peer is connected. To avoid to
send the vCard everytime, a state is written in the cache directory.

In the future, a method to update the vCard as soon as the client
updates its profile will be possible.

Change-Id: I3801cbe04b3441f67ea6685aa2047e5a545958e5

Sébastien Blin authored 4 years ago and Adrien Béraud committed 4 years ago

With this patch, Jami will be able to use a current opened socket with a peer
to transmit files. This means that no ICE negotiation will be necessary
and if multiple files are transferred via the same socket

Change-Id: I8eaf7c38595bbf8e86098d6c8ad21afc9210fe6b
Gitlab: #228

Change-Id: Ibd1c8649483cb9a43d65a41a580968e3ca25561f

Change-Id: I28f193813ad72ee5936ef0be7f252c40c3b748ee

Andreas Traczyk authored 5 years ago and Sébastien Blin committed 5 years ago

- any functions that get strings from windows apis, are converted
  and stored as utf8 strings internally
- anytime an internal utf8 string is passed as a parameter to a
  windows api function, it is converted to a wstring
- all of these translations apply currently to file paths
- a windows client should make sure to setlocale to utf8 because
  we use some dependencies that call mbstowcs and wcstombs instead
  of WideCharToMultiByte/MultiByteToWideChar

Change-Id: Ic13f55ace491e1088c0a3d436d3a0d02df7216c3
Reviewed-by: Sébastien Blin <sebastien.blin@savoirfairelinux.com>

Sébastien Blin authored 5 years ago and Adrien Béraud committed 5 years ago

+ Remove some unused using
+ Remove useless std::move
+ Reduce duplicate code
+ Avoid some copy

Change-Id: I7bdbc14aa1b79ce10d30f2f1ef005dd8839de62a

Change-Id: I635ec67b90fc1ae90556a208f451750ceebbfeaa

Change-Id: Ieb8d1c6d366f39fbbb83f405af659e04c884caa2

Change-Id: Id5673ba9f2ec519070cc112685dea5ced94c3b38

Change-Id: I67e03e6711a46e6d241ee249bfa480ac76abfa93

Currently, when an incoming request is cancelled the transfer id
is lost. This patch avoid this case and allow the cancel part in
p2p.cpp to clear the data related to this transfer.

Change-Id: Ia5b69b514fce19e80ee3344d40eb395470212ef3

* rename namespace from ring to jami
* rename logs methods from RING_* to JAMI_*
* rename RING_VIDEO to ENABLE_VIDEO

Change-Id: Ic98498652d7059fafe58a96220d565bcdfa53658

Change-Id: I0c6cb7a45ceb142717519f4dfd2a8541aea5db5d

Change-Id: Ia4ed75d04a284efa0763c917aeaa2f08863a87cb

Change-Id: I0c696b635bd7940d9d9803ecb577ef436943ded3
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

Sébastien Blin authored 6 years ago and Philippe Gorley committed 6 years ago

Currently, when a file is sent, the peer needs to accept the transfer.
So, connections with this peer will be opened until the peer accepts or
not the file. Since the multi-device support, it's a problem because
the peer has to accept/refuse the transfer on each devices.

To avoid to leave unused connections while we are using the turn,
we need to close these connections. This patch add a timeout to
outgoing file transfers. So, after 10 minutes with the status
awaiting peer, the connection is closed and the transfer canceled.

NOTE: the peer will still see the awaiting_host status even if the
connection is closed, but it's a known bug and it will need a major
change of the blocking startNewFile function in FtpServer.

Change-Id: Ic6e3a2bfebad92cc5c64f5ac2355c3c3765752c9
Reviewed-by: Philippe Gorley <philippe.gorley@savoirfairelinux.com>

With the current implementation, when a user send a file to a contact
who got several devices connected, a request will be sent to all of
these devices and the first which answer will get the transfer. So,
a user can't know on which device they will get the file.

With this patch, in the same configuration the peer will receives
the file on all of its devices and add the possibility to accept
or refuse the file. To avoid to see multiple file transfers because
a peer has several devices, I introduced a OptimisticMetaOutgoingInfo
which represents the best current state of the transfer (for example,
if one subtransfer is ongoing and one failed (cause refused) it will
show the outgoing one).

This is an ongoing work, in the near future we must:
+ Give the ability to clients to see the real status of each
subtransfer (with the ability to cancel/retry transfer by devices)
+ Add a timer to close awaiting transfers to avoid to let a unused
connection for too long.

Change-Id: I84eb243bff2bfdc087a83dd7eced45c361f27d16
Reviewed-by: Philippe Gorley <philippe.gorley@savoirfairelinux.com>

Sébastien Blin authored 7 years ago and Andreas Traczyk committed 7 years ago

This patchs implies a lot of changes for file transfer.
First, a TURN connection is made only for one file transfer. This
allows us to cancel a transfer by closing this connection without
cancel future file transfers. The TURN connection is closed when a
transfer is finished or canceled. Avoid to keep unused connections.
Second point, a ftpserver uses the id of its attached stream.

Note: removed unimplemented refuse and abortStream in peer_connection

Change-Id: I65ba104066de0494ba5a7954f0fad63eb2c9d6ac
Reviewed-by: Andreas Traczyk <andreas.traczyk@savoirfairelinux.com>

Andreas Traczyk authored 7 years ago and Sébastien Blin committed 7 years ago

Change-Id: Ie3c46211dbd09d6b4eb5f68bf730ab08dc675714
Reviewed-by: Sebastien Blin <sebastien.blin@savoirfairelinux.com>

- simplifies client implementations
- can be used as a persistent id for future tracking of unfinished transfers

Change-Id: Ib03b2e2a5ec196735a0e21bdc99801894d9dfabe

Change-Id: Ida39c9b3a30496061f37a4c1a13758dccf06d134

- implement "cancel" file transfer method
- fixing various bugs found during testing

Change-Id: Iea23cb3e2cdf8b4649afdf7436ec0701f9b67bdf

Guillaume Roguez authored 7 years ago and Adrien Béraud committed 7 years ago

Add support for "wait_peer_acceptance" state.
Now a sender blocks until it receives acceptance
from receiver.

Change-Id: I3252a9c20c1ef2f2e1da573c570b99d816cbb451
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

GTK client uses D-Bus, so is unable to forward exceptions.
This causes crashes of daemon (unhandled exception).

This patch changes DataTransfer API to not throw (noexcept).
This is an important changes, not backware compatible,
so the API version has been modified consequently.

Change-Id: I9f2a2fe1732b2622ace16225b6e792dc15383ba1
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>

* protect against write() call on a closed incoming stream.
* Use DataTransferEventCode::closed_by_peer when
data are not completly received, else ataTransferEventCode::finished
is emitted.

Change-Id: I15f2518f70afbe1bfe8aa8813cbca676dec4360a
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

At reception, output file was not closed due to silented exception
before the close() call.

Change-Id: I9f2bb2dd29db74391fb95acfa97863b4a118189f

Trigger "created" signal of data transfer after
the id is registred, not before.
This fix getTransfer() called in the created emit call scope.

Change-Id: I0d02a3902c56fd60fced60d90248c6ac5e13ae41
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

remove a start done right after file accepted.

Change-Id: Ia0be8f08de627041c3d5e07478922fb59c2d0be2

FTP/IncomingFileTransfer classes were not designed correctly
to talk between them.
This patch moves the file handling into IncomingFileTransfer class
and FtpServer only handles FTP protocol.

Change-Id: Ia12777dcb064b69b04bd5b6b3defc3ba3e84b2c3
Reviewed-by: Olivier Soldano <olivier.soldano@savoirfairelinux.com>

Change-Id: I1ef88bc640f79790aad2b5285ea2c776aa8cd366

Fill AccountId and Peer field of outgoing and incoming data transfers.

Change-Id: I772e9c4560fb63c30e33c341cd296cacd6a45df6
Reviewed-by: Anthony Léonard <anthony.leonard@savoirfairelinux.com>