- Jun 11, 2021
-
-
Sébastien Blin authored
Add mechanism to re-ask for transfers and sendProfile with new logic GitLab: #524 Change-Id: I9f10328ff0e2bd9128e2d7d1afd7fa272dd14cdf
-
Sébastien Blin authored
Change-Id: I142e017e290c643a73f2b2b422533ec8d7cc0483
-
Sébastien Blin authored
add API to ask for a failed transfer. This can be used when the client detects a transfer they doesn't have yet. It will ask all members of the conversation to send the transfer back. GitLab: #136 Change-Id: I1484298c4fa0eabb614132e22d8032612e14b949
-
Sébastien Blin authored
Sometimes a non swarm can send a text message via the DHT but not the trust request confirm. In this case, the discussion must use the old path. Change-Id: Id0d5223c830abe0840bef167b4be50abc276a72c
-
Sébastien Blin authored
Change-Id: Ib8fcbbb95a4df84e297ad468b8b4b239a172a153
-
Change-Id: I136f5ba49f14a379ec6dce37fbd837e38d90f549
-
Sébastien Blin authored
Pass all methods in async and on the io pool if they write into the repository. Moreover, now MessageReceived guarantees to be ordered if announced. e.g. if a parrallel merge and commit are done previously if the merge was done before the commit you could receives MessageReceived(merge) after MessageReceived(commit). Now it's impossible. So the linearizedParent is guaranteed to be announced before. Change-Id: If4b94f19f5bf5abd4841fc19074231e3411e077d
-
Sébastien Blin authored
If a TrustRequest is confirmed without conversationId this means that the contact don't support swarm. So, we can drop the conversation and fallback on old path. Change-Id: Ic8238312fe79e10f340460d20880dbfc8dccf3f7
-
Sébastien Blin authored
Change-Id: Ia80930bdec6b5e125fd559fcd6b125a45b4eba0c
-
Sébastien Blin authored
Change-Id: Ic1e002a1e8edf79c5c392e707dd857c7e88667ec GitLab: #319
-
Sébastien Blin authored
GitLab: #320 Change-Id: I82b049cfa83f1e3e38a106bce142c1e7ce31557c
-
Jamiaccount add a listener while the state is been changed. This can result in reallocation of the underlying vector while it's been iterated, resulting in a read after free. -------------------------------------------------------------------------------- ==930034==ERROR: AddressSanitizer: heap-use-after-free on address 0x603000991900 READ of size 8 at 0x603000991900 thread T1 #0 0x55555a8a6dcb in /ring-project/daemon/src/call.cpp:94 #1 0x55555a8c8483 in /usr/include/c++/11.1.0/bits/invoke.h:61 #2 0x55555a8c654a in /usr/include/c++/11.1.0/bits/invoke.h:111 #3 0x55555a8c4c4e in /usr/include/c++/11.1.0/bits/std_function.h:291 #4 0x55555a8d5102 in /usr/include/c++/11.1.0/bits/std_function.h:560 #5 0x55555a8af158 in /ring-project/daemon/src/call.cpp:270 #6 0x55555a8aff7a in /ring-project/daemon/src/call.cpp:296 #7 0x55555a8b987d in /ring-project/daemon/src/call.cpp:575 #8 0x55555a8b5067 in /ring-project/daemon/src/call.cpp:482 #9 0x55555a8c225b in /ring-project/daemon/src/manager.h:1047 #10 0x55555a8ca928 in /usr/include/c++/11.1.0/bits/invoke.h:61 #11 0x55555a8c88d8 in /usr/include/c++/11.1.0/bits/invoke.h:111 #12 0x55555a8c6878 in /usr/include/c++/11.1.0/bits/std_function.h:291 #13 0x555559cff4a8 in /usr/include/c++/11.1.0/bits/std_function.h:560 #14 0x55555aaae8a1 in /ring-project/daemon/src/scheduled_executor.cpp:137 #15 0x55555aaaaf8f in /ring-project/daemon/src/scheduled_executor.cpp:32 #16 0x55555aab4a2f in /usr/include/c++/11.1.0/bits/invoke.h:61 #17 0x55555aab48ea in /usr/include/c++/11.1.0/bits/invoke.h:96 #18 0x55555aab47bf in /usr/include/c++/11.1.0/bits/std_thread.h:253 #19 0x55555aab46f5 in /usr/include/c++/11.1.0/bits/std_thread.h:260 #20 0x55555aab46ad in /usr/include/c++/11.1.0/bits/std_thread.h:211 #21 0x7ffff45583c3 in /build/gcc/src/gcc/libstdc++-v3/src/c++11/thread.cc:82 #22 0x7ffff649f258 in /usr/lib/libpthread.so.0+0x9258 #23 0x7ffff38e45e2 in /usr/lib/libc.so.6+0xfe5e2 0x603000991900 is located 0 bytes inside of 32-byte region [0x603000991900,0x603000991920) freed by thread T0 here: #0 0x7ffff769fd69 in /build/gcc/src/gcc/libsanitizer/asan/asan_new_delete.cpp:172 #1 0x55555a1e3dc3 in /usr/include/c++/11.1.0/ext/new_allocator.h:139 #2 0x55555a18f942 in /usr/include/c++/11.1.0/bits/alloc_traits.h:492 #3 0x55555a12a9c1 in /usr/include/c++/11.1.0/bits/stl_vector.h:354 #4 0x55555a12b390 in /usr/include/c++/11.1.0/bits/vector.tcc:500 #5 0x55555a0e1a7c in /usr/include/c++/11.1.0/bits/vector.tcc:121 #6 0x55555a0b8c40 in /ring-project/daemon/src/call.h:286 #7 0x555559f43b69 in /usr/include/c++/11.1.0/bits/jamiaccount.cpp:675 #8 0x555559f3bf91 in /usr/include/c++/11.1.0/bits/jamiaccount.cpp:483 #9 0x555559f39cb7 in /usr/include/c++/11.1.0/bits/jamiaccount.cpp:449 #10 0x55555a838f0e in /ring-project/daemon/src/manager.cpp:3350 #11 0x55555a7f7aef in /ring-project/daemon/src/manager.cpp:1015 #12 0x555559d3c828 in /usr/include/c++/11.1.0/callmanager.cpp:67 #13 0x555559c70b5a in /ring-project/daemon/bin/dring+0x471cb5a #14 0x555559c7b71a in /ring-project/daemon/bin/dring+0x472771a #15 0x555559c943af in /ring-project/daemon/bin/dring+0x47403af #16 0x555559d06102 in /ring-project/daemon/bin/dring+0x47b2102 previously allocated by thread T0 here: #0 0x7ffff769eca1 in /build/gcc/src/gcc/libsanitizer/asan/asan_new_delete.cpp:99 #1 0x55555a21b9e8 in /usr/include/c++/11.1.0/ext/new_allocator.h:121 #2 0x55555a1e4083 in /usr/include/c++/11.1.0/bits/alloc_traits.h:460 #3 0x55555a190197 in /usr/include/c++/11.1.0/bits/stl_vector.h:346 #4 0x55555a12af48 in /usr/include/c++/11.1.0/bits/vector.tcc:440 #5 0x55555a0e1a7c in /usr/include/c++/11.1.0/bits/vector.tcc:121 #6 0x55555a0b8c40 in /ring-project/daemon/src/call.h:286 #7 0x55555a8aaaaa in /ring-project/daemon/src/call.cpp:92 #8 0x55555abcb76d in /usr/include/c++/11.1.0/bits/sipcall.cpp:89 #9 0x55555a7c3341 in /usr/include/c++/11.1.0/ext/new_allocator.h:156 #10 0x55555a7c2185 in /usr/include/c++/11.1.0/bits/alloc_traits.h:512 #11 0x55555a7bfe6d in /usr/include/c++/11.1.0/bits/shared_ptr_base.h:519 #12 0x55555a7bcaa4 in /usr/include/c++/11.1.0/bits/shared_ptr_base.h:650 #13 0x55555a7b85e1 in /usr/include/c++/11.1.0/bits/shared_ptr_base.h:1337 #14 0x55555a7b2d2c in /usr/include/c++/11.1.0/bits/shared_ptr.h:409 #15 0x55555a7af189 in /usr/include/c++/11.1.0/bits/shared_ptr.h:861 #16 0x55555a7abce0 in /usr/include/c++/11.1.0/bits/shared_ptr.h:877 #17 0x55555a7a4782 in /ring-project/daemon/src/call_factory.cpp:54 #18 0x555559f39b16 in /usr/include/c++/11.1.0/bits/jamiaccount.cpp:445 #19 0x55555a838f0e in /ring-project/daemon/src/manager.cpp:3350 #20 0x55555a7f7aef in /ring-project/daemon/src/manager.cpp:1015 #21 0x555559d3c828 in /usr/include/c++/11.1.0/callmanager.cpp:67 #22 0x555559c70b5a in /ring-project/daemon/bin/dring+0x471cb5a #23 0x555559c7b71a in /ring-project/daemon/bin/dring+0x472771a #24 0x555559c943af in /ring-project/daemon/bin/dring+0x47403af #25 0x555559d06102 in /ring-project/daemon/bin/dring+0x47b2102 Thread T1 created by T0 here: (...) #2 0x55555aaab6bd in /ring-project/daemon/src/scheduled_executor.cpp:27 #3 0x55555a7e61b3 in /ring-project/daemon/src/manager.cpp:456 #4 0x55555a7eea6c in /ring-project/daemon/src/manager.cpp:736 #5 0x55555a7ee39f in /ring-project/daemon/src/manager.cpp:711 #6 0x555559d3b25f in /ring-project/daemon/src/ring_api.cpp:57 #7 0x555559ae17db in /ring-project/daemon/bin/dring+0x458d7db #8 0x555559ad1285 in /ring-project/daemon/bin/dring+0x457d285 #9 0x555559acf5e1 in /ring-project/daemon/bin/dring+0x457b5e1 #10 0x555559acf292 in /ring-project/daemon/bin/dring+0x457b292 #11 0x555559ace828 in /ring-project/daemon/bin/dring+0x457a828 #12 0x555559acdb01 in /ring-project/daemon/bin/dring+0x4579b01 #13 0x555559acd33f in /ring-project/daemon/bin/dring+0x457933f #14 0x555559acbc8d in /ring-project/daemon/bin/dring+0x4577c8d #15 0x555559aca91b in /ring-project/daemon/bin/dring+0x457691b #16 0x555559ac8eec in /ring-project/daemon/bin/dring+0x4574eec #17 0x555559ac693b in /ring-project/daemon/bin/dring+0x457293b #18 0x7ffff380db24 in /usr/lib/libc.so.6+0x27b24 SUMMARY: AddressSanitizer: heap-use-after-free /ring-project/daemon/src/call.cpp:94 in operator() Shadow bytes around the buggy address: 0x0c068012a2d0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c068012a2e0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c068012a2f0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c068012a300: fa fa fa fa fa fa fa fa fa fa fa fa fa fa 00 00 0x0c068012a310: 00 00 fa fa fa fa fa fa fa fa 00 00 01 fa fa fa =>0x0c068012a320:[fd]fd fd fd fa fa 00 00 00 07 fa fa fa fa fa fa 0x0c068012a330: fa fa fd fd fd fd fa fa fd fd fd fa fa fa fd fd 0x0c068012a340: fd fa fa fa 00 00 01 fa fa fa fa fa fa fa fa fa 0x0c068012a350: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c068012a360: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c068012a370: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user:f7 Container overflow: fc Array cookie:ac Intra object redzone:bb ASan internal: fe Left alloca redzone: ca Right alloca redzone:cb Shadow gap: cc ==930034==ABORTING -------------------------------------------------------------------------------- Change-Id: I23b4d1017b53a2d7fe224c92527254015e853168
-
Adrien Béraud authored
Change-Id: I8ae187c0a175c05bc7e1421999ff067935b32dbb
-
Adrien Béraud authored
Change-Id: I1b4dd0f9cba07cc343a7dfb707333f210359503a
-
Aline Gondim Santos authored
Change-Id: Ie8513b083d696604b36d6b3ecd868ce184a398d0
-
Modify the CallSignal::MediaNegotiationStatus signal to report the list of negotiated media in addition to the status event. Gitlab: #564 Change-Id: I9ac77656f4f268317ddd87b085f1581ceac0b5b9
-
Check peer's Daemon version and ignore media change request action from the client if the the peer does not support the feature. Also bump Daemon version to 10.0.2 Gitlab: #551 Change-Id: Ifd105d2fe2706b4667f5bafabcb3d91e771e7299
-
If multi-stream is disabled and a re-invite is received, the re-invite answer must use the current media list instead of creating a new one. Also, report MediaNegotiationStatus event using the parent call ID if it's a subcall. Gitlab: #445 Change-Id: I33cdc5cd4ed8a394d60d8ffb5d506a279fde0b3f
-
Change-Id: Iaae6944d08304df08c916b4ba901e8530f220824
-
Sébastien Blin authored
Change-Id: I717f185f4217f234bee7eb5564acf16940f114c3
-
- Jun 09, 2021
-
-
`memcpy()` has the `__nonnull__` and ASAN doesn't like it even tho the length of the buffer is 0. Thus, using a dummy buffer on the stack. -------------------------------------------------------------------------------- #0 0x55555a0a1b8a in /usr/include/msgpack/v1/sbuffer.hpp:74 #1 0x55555a1dcfd3 in /usr/include/msgpack/v1/pack.hpp:623 #3 0x55555a11eab2 in /usr/include/msgpack/v1/pack.hpp:1311 #4 0x55555a35c1c5 in /ring-project/daemon/src/jamidht/multiplexed_socket.cpp:676 #5 0x55555a363879 in /ring-project/daemon/src/jamidht/multiplexed_socket.cpp:945 #6 0x55555a35554e in /ring-project/daemon/src/jamidht/multiplexed_socket.cpp:459 #7 0x55555a34e0c0 in /ring-project/daemon/src/jamidht/multiplexed_socket.cpp:247 #8 0x55555a37298f in /ring-project/daemon/src/jamidht/multiplexed_socket.cpp:75 (...) -------------------------------------------------------------------------------- Change-Id: Ibc8c8d808c233da1649f556466b24d68decf85e8
-
Olivier Dion authored
Change-Id: If1dbdefb546e56e06768b0dcdacad9276c5a5d36
-
Change-Id: I08d78c5a243adf1ab78e24528f5798c8a49d3350
-
Signal handlers can be called after lifetime of stack variables within `wait_for_*` functions. Thus, moving or copying the accounts vector to avoid race condition. Change-Id: I25eaed11e04b3c3cc6e40662bef326c4fe319603
-
Change-Id: I2369a62d9e035c0ee6aaacf92175ff84ceb13fc7
-
Change-Id: Ied9321ae92e6ca963fcb19ea5b018e5f11b461cf
-
Change-Id: Ie040f336b8c6c8dc32386f0c1ac31fbcf1ad7820
-
- Jun 08, 2021
-
-
Change-Id: I3c23b7ed144d5e26c030180d306cee0179c10b4d
-
Sébastien Blin authored
Change-Id: I9c0b24842e44eae098307fda5e27f341031074fa
-
Use custom JAMI environment variables to change data, config, cache dir on runtime Change-Id: I5d345922ba1aba2a4e372c85554b104e4cef8594
-
- Jun 07, 2021
-
-
Kateryna Kostiuk authored
Change-Id: I4ecc6285cd036c8b6f907d5ee6daf2f050a78bd9
-
- Jun 04, 2021
-
-
Adrien Béraud authored
Change-Id: I40a4f6be0ed1cda1df1ca529fa16f3a61d4d93db
-
Change-Id: I4ef0f1168f94d35b049735a6c739b3bf4d489aa5
-
Change-Id: I88c44743227dc264a7bae899caccbb02b7a29a69
-
- Jun 03, 2021
-
-
Andreas Traczyk authored
Change-Id: I22f887adda3e1a31a68ec07bfcf4418665e4b48f
-
- Jun 02, 2021
-
-
Sébastien Blin authored
Else, the closing is not guaranteed due to potential 481 errors when invite is deleted before the message sent. Change-Id: I7e02b55c7967e336ca6357869034103a36ecb262 GitLab: #559
-
Olivier Dion authored
Change-Id: I783cca7a53677dbaf1815aa6d0a5904f14baf0fd
-
Olivier Dion authored
Change-Id: Icf4453467c246ac29b3d178e73380fbeb174d3cd
-
Olivier Dion authored
Load actors from YAML description for unit tests. Change-Id: Id1840e2bd7244abf902c9be95589b82503c72840
-
- Jun 01, 2021
-
-
Sébastien Blin authored
Change-Id: I0fbcc84207da1834601a99680842ee0da0dbfde8
-