Mohamed Chibani authored 3 years ago and Sébastien Blin committed 3 years ago

When a new media list is provided (during a media change request
for instance), the media source and source type will be updated
only if set in the new media attribute list. This will prevent unwanted
overwriting of media source and source type.
This patch will fix the ut_media_negotiation unit test.

Gitlab: #576

Change-Id: If6f994def1e113265eeff0cce93fe5d314dffd5d

If the user decides to transmit its account archive via a webservice
in some case the webserver can re-compress the file resulting to a
gunzip file into a gunzip file. We can check the header of the file
to be able to detect this case.

Then, replace inflateInit by inflateInit2 with better header detection
to avoid header errors. Cf http://www.zlib.net/manual.html#inflateInit2

Change-Id: I1421affa8815ab347b439ef2e505da10275c80ff
GitLab: #575

Change-Id: I5340a0215512be416a618c526f8a0962c8401087

Gitlab: #590

Change-Id: Ia2f030e475eb269a7f9ccb7540fd1fc0c80f5a5b

Sébastien Blin authored 3 years ago and Olivier Dion committed 3 years ago

Note:

Merged upstream (so deleted):
0010-fix-pkgconfig.patch
0014-Add-new-compile-time-setting-PJ_ICE_ST_USE_TURN_PERM.patch
0015-update-local-preference-for-peer-reflexive-candidate.patch
0016-use-addrinfo-instead-CFHOST.patch
0017-CVE-2020-15260.patch
0018-CVE-2021-21375.patch

Merged for 2.12:
0019-ignore-down-interfaces.patch
0020-ignore-addresses-for-RFC7335.patch

Also, fix the assertion in ice_transport.cpp cause
user_mapping_cnt can be equals to PJ_ICE_MAX_COMP.

Change-Id: If6fee261e89c34640519a6b61e94391b57363a22
GitLab: #509

Change-Id: Idab58d884268f94048c0ca52adb2bb5397aac95f

Change-Id: I72147bfa7fcf06d69a9cd911300ce3dada1f2649

Change-Id: I78e539ba9702bba09afb0f6c3bacd115e3fde737

Fixing a deadlock that can occur with this path:
startStream -> waitForDevices (blocks with mutex locked) -> hardwareFormatAvailable (deadlock on mutex)

Change-Id: I808513e62618986b9a4217d3e70f57cb91cef595

Change-Id: I48a46f4dacd78f259be79547a6d8e4a02ae1c5f5

If `DRing::acceptWithMedia()` is called within an `IncomingCall` signal handler,
then `processIncomingCall` will wrongly try to answer the same call.

Gitlab: #589

Change-Id: Ica7a5c17852d83e6228e71e0f9a2a83b24cb315b

When a call is added to a conference, the control of the mute/un-mute
state of the media of the call is taken over by the conference, and
the mute state of the participating calls will be controlled by the
state of the local host set in the conference, which basically consists
of attaching/detaching the source to/from the mixer. Currently the local
host mute state might not be correctly initialized, leading to
inconsistent mute states.
The proposed changes will correctly set the local host state according
to the initial mute states of each call joining the conference.

Gitlab: #576

Change-Id: I0a746aae82da57222cc7ff91c2e39a1a2bbaff8e

Gitlab: #567

Change-Id: I7f9eb1f9eb13250a999f7b26441ea7c47b81f796

Sébastien Blin authored 3 years ago and Adrien Béraud committed 3 years ago

verifyOcsp takes a callback with arguments passed by reference.
However, if the method finishes (verifyCertificateWrapper) cert
will be destroyed and references potentially invalidated.
So, instead of waiting on a condition variable use a future to
be sure that the cert is used before destruction.
The callback is always called by sendOcspRequest with a similar
timeout so also remove the useless timeout.

Change-Id: If1a8eba70e13d2d613b758ad24629efa4fe57bb3
GitLab: #577

Dolt doesn't provide the performance benefits it promises, so drop it
to simplify the moving parts of the Autotools build system.

Also remove unused M4 modules.

* m4/dolt.m4: Delete file.
* m4/ax_boost_base.m4: Likewise.
* configure.ac: Do not call DOLT.

Change-Id: I58d286457005ad82129e089679c52933989c59a8

Adrien Béraud authored 3 years ago and Sébastien Blin committed 3 years ago

Change-Id: Ia395103ba2ec2ec85400cf710a07c40888568d68

For whatever reason, a conversation can be malformed. This should
be detected and the conversation not loaded. The conversation
will be removed and re-synced if necessary.

Change-Id: I40e78564559e7f09159ceba4d263a4ea75b25794

Maxim Cournoyer authored 3 years ago and Maxim Cournoyer committed 3 years ago

Automated using the following commands:

  $ mv src/{dring,jami}
  $ git grep -l src/dring | xargs sed -i 's,src/dring,src/jami,g'
  $ git grep -l '#include "dring/' | \
    xargs sed -i 's,#include "dring/,#include "jami/,g'
  $ git grep -l 'dring.h' | xargs sed -i 's,dring.h,jami.h,g'

And finally,

  $ git grep -l 'dring' | xargs sed -i 's,dring,jami,g'

  $ files=$(find -name '*dring*' | sort)
  $ for f in $files; do mkdir -p "$(dirname "$f")"; \
      mv "$f" "$(echo $f | sed 's/dring/jami/g')"; done

To resolve a bad renaming favorably:

  $ git grep -l -i AlsaCarjami | \
    xargs sed -i -E 's/([Aa])lsaCarjami/\1lsaCardRingtone/g'

The above renaming command is not perfect, so some hand-tuning was
required to complete it.

* src/manager.cpp (Manager::ManagerPimpl::retrieveConfigPath):
Preserve the dring.yml configuration file name, until we add something
to migrate (rename) it to jami.yml.
* man/dring.pod: Delete.
* bin/dbus/jamid.pod: Move to ...
* man/jamid.pod: here.
* bin/dbus/meson.build (jamid_targets): Normalize man section to the
pre-existing 1 and adjust accordingly.
* src/jami/def.h (dring_EXPORTS): Rename to ...
(jami_EXPORTS): ... this.

change-Id: I9828be6da9c711ab2f22c4d1b9539fea89d7b6fb

This logic was added via 9d9a6b3d,
but this will give potential deadlocks, because pj's group lock
will be locked at this point. So we will have:
group-lock->callMutex_
and other methods like SIPCall::hangup will try to lock:
callMutex_->group-lock
causing a deadlock.

The original issue was adding this line due to a use after free,
however since then we fixed the ref counter of inv, so it should
be a valid fix.

Change-Id: I2fdc236ca63487634ebf2659ecdebb8e0c3234fe
GitLab: #586

Change-Id: I33c732784833808d092cefa402669a0bbdc0561e
GitLab: #582

Gitlab: #583

Change-Id: Iddd1b582595daee498b383a11c6323546d14bef4

If `monitorLog` is set to true in between the copy of variadic arguments and
branch to `vnsprintf`, it results in SEGFAULT.

Change-Id: I610b950cec22e9b7123cca709e2f145b1bc1be16

Gitlab: #570

Change-Id: I87f476082f0f04b342e737e523eae976b0717bca

Olivier Dion authored 3 years ago and Sébastien Blin committed 3 years ago

Increment of the invite session has to be done before SIPCall takes a reference
to it.

Otherwise, `pjsip_inv_dec_ref()` will be called internally by PJSIP when the
reference counter has reached 0.  This happen when `SIPCall::setInviteSession()`
is called in `invite_session_state_changed_cb()`, resulting in the deletion of
the invitation.

Change-Id: Icba0985ea26ce5dec462bd124cca4dd2187d6a47

Change-Id: I0f0a926996d34ae22051f0247e36575ab755d0ba

Rework the test to use two audio streams instead of audio+video.
This is needed to run the test on environments where the camera
is not available (e.g. Docker). For this specific test, the media
type is irrelevant, so using two audio media is acceptable.

Gitlab: #516

Change-Id: Idc4911d5aea5ffdd931bd7d63516ed484344d41c

Olivier Dion authored 3 years ago and Sébastien Blin committed 3 years ago

Change-Id: I1acac4dd8e87d2ffe1c63638d03fd28c6749adef

Change-Id: I702ab3422c3fd6bd528fe65a5541c98150a5722d

Change-Id: I68e954bc8de9548a9da0026c014f27141e0b7ec0

Change-Id: Ice706b3c5384cb8bec7becfc6209658a78b9ac9a

Olivier Dion authored 3 years ago and Sébastien Blin committed 3 years ago

`last_REMB_*` can be at `time_point::min()` when `delayMonitor()` is called.  This
results in a signed integer overflow, which UBASAN doesn't like.

Fix this by setting `last_REMB_*` to `clock::now()` before setting callback.

Change-Id: I0b24d759927c2eb7e23253a16333ba54dc3f9edf

Aline Gondim Santos authored 3 years ago and Kateryna Kostiuk committed 3 years ago

Change-Id: I13b63eff7f7b729ece6ac3d16cd4d36767a20464

Change-Id: Ib943587e49bcbf16104cf3bbc206e30bc3448f82

Mohamed Chibani authored 3 years ago and Sébastien Blin committed 3 years ago

Currently, when an empty offer is received, a media offer is
generated with audio, and video if enabled in the account.
Now, the generated offer will include only audio. Both
participants can add video to the call if they wish.
Also some code clean-up

Gitlab: #556

Change-Id: Id51bf44b2b84fd9341de4b67bf53963614088ef8

Olivier Dion authored 3 years ago and Sébastien Blin committed 3 years ago

Change-Id: I67825b04f1fead3d4267564e4c366cb54037c593

This seems to avoid a heap buffer overflow. Anyway, we only add data at the
end of the buffer so the deque has no need.

Change-Id: I8f3932599a065f22b11adc701ededfb5ebedfff8

Change-Id: I62f93b4b0706863debc9595b0b4646c3b0974b52

This can re-generate MessageReceived for already received messages. If we
are not behind from, this means we are up-to-date and no-need to re-announce.

Change-Id: I890ec20117235aeec56e4a7d3f720c1193e9633c

avoid any possible race condition. shutdown the sock when onShutdown is set

Change-Id: I0e7a5e940267154aec4417c8b653d19b1f54430c

Adrien Béraud authored 3 years ago and Sébastien Blin committed 3 years ago

If we receive EOF, didn't the peer already closed the socket ?

Change-Id: I06ae908b49ddd4ba0a5eb43ff25f51da1f15cc21