Add a return to an error handling of unwaited rx IM msg.

Coverity CI # 1296815

Change-Id: Ib4503f639e80f7a24e039043f70f8597b6f141d4
Tuleap: #909

This patch fix two calls to strdup() without any free().

Change-Id: I8619794e71d4165c154ba6ddd89bf6237e444a67
Tuleap: #906

Set true as default value to members:
allowPeersFromHistory_
allowPeersFromContact_
allowPeersFromTrusted_

Coverity CID # 1369576

Change-Id: I38499608ee35692e96c511f08d261eea8ad9b72b
Tuleap: #909

Set default value of mutex_nesting_level_ to 0.

Coverity CID # 1291689

Change-Id: Ib794fe5a90679669c837e2ad8064998caae01f42
Tuleap: #909

AC_CHECK_LIB was not correctly checking for the presence of zlib.
We use PKG_CHECK_MODULES instead to add -lz to libring_la_LDFLAGS.

Change-Id: Icfffb898030f886aae8c2c82dc5327f923f0f78e
Tuleap: #746
[stepan.salenikovich@savoirfairelinux.com: modified to use PKG_CHECK_MODULES and ZLIB_LIBS variable instead of -lz]
Signed-off: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

Init default value of caValidationOutput_ member of TlsValidator class.
This prevents warns from static coverage tests.

(issue detected by coverity.com analysis)

Change-Id: Ib9a930bb233208cd99b7003d1a72b6d8003e3e9d
Tuleap: #909

The file size was wrongly checked in loadFile,
giving a always true comparaison.

(issue detected by coverity.com analysis)

Change-Id: I2aa4f5c737df3a3b815caebc97bdc3820df8b534
Tuleap: #909

remove unreachable code

Change-Id: I6c9fbccc0693d9edfc3367477db60fc04a4ddba0
Reviewed-by: Stepan Salenikovich <stepan.salenikovich@savoirfairelinux.com>

When receiving an incoming SIPS or Ring call, enforces the
secure state of the media as it should be per the SIP
standard.

Also prevents to accidentally configure an insecure
transport on a secure call.

Change-Id: I28836c76f79218a026b07d7c182adbaaf50aedbb
Tuleap: #901

This patch prevents SocketPair::getRtcpInfo() to lock a mutex
during a consequent memory copy and reduce copy cpu load by using
move iterators.

Change-Id: Ie729cb0677c45639f5a92ae842e93032c26f1a02

Adrien Béraud authored 9 years ago and Guillaume Roguez committed 8 years ago

PA default device is selected by passing nullptr to
pa_stream_connect_playback and pa_stream_connect_record,
which is the way described in the official documentation:
https://freedesktop.org/software/pulseaudio/doxygen/stream_8h.html#ab9544f6677af133fbe81bf8a21eb489c



We used to attempt to guess the default device by incorrectly using
information from the PA server (pa_context_get_server_info).

Change-Id: Ifa8109b0ba86b223a2eca3ff136822b338fbf730
Reviewed-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

Adrien Béraud authored 9 years ago and Guillaume Roguez committed 8 years ago

Cleanup and factorise incoming call matching API.

Change-Id: I4b6ceb24372a189c3bf3b5bbbaf97c59912140ec
Reviewed-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

This reverts commit 1e249e4f.

The idea is "good" in theory, but the implementation of
setSecure() causes an exception error.
We need to find a better solution.

Change-Id: I4062388782c07ba3d5a9ab8eb9df655be676d9e4

Adrien Béraud authored 8 years ago and Guillaume Roguez committed 8 years ago

Change-Id: Ia59165ea7d200c7c7cde666edb3918517119f199
Reviewed-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

This caused an "infinite loop" for audio media resulting
in CPU being overcharged for nothing

This fix the problem on MacOS and on GNU/Linux when using PulseAudio
There is still a similar problem with Alsa.

Change-Id: I70e111c59125143d60b657898b04a0b65a638bd6
Tuleap: #576

Change-Id: I802006aa7a139413da6e857e2030f817d06e9941
Reviewed-by: Andreas Traczyk <andreas.traczyk@savoirfairelinux.com>
Reviewed-by: Guillaume Roguez <guillaume.roguez@savoirfairelinux.com>

Adrien Béraud authored 8 years ago and Guillaume Roguez committed 8 years ago

SIP mandates a secure media transport when using
a secure SIP transport. To respect this, Ring
disables media when a secure call has no
secure media configured (sipcall.cpp:834).
Instead of failing, a better behavior would be to
force enabling media encryption when TLS is active at
the account level.

Change-Id: I25b77248be5d50bf016f959f0a06ec4850fa642e
Reviewed-by: Andreas Traczyk <andreas.traczyk@savoirfairelinux.com>

Andreas Traczyk authored 8 years ago and Andreas Traczyk committed 8 years ago

Add replace dirname with _splitpath to facilitate native Windows
building.

Change-Id: I57712f9f9642c221555b522c312484fed0012f03
Tuleap: #797

The Microsoft compiler will include the common header <intrin.h>
regardless of the use of quotes. The file "intrin.h" should be renamed,
and all references to it changed, as well as defining the UNUSED macro
to nothing on the Windows platform.

Change-Id: Id04d36e70d149746be8d78eed09aa963514b2810
Tuleap: #801

Change-Id: I439bec2be0978e991511e42af464da765939d593
Tuleap: #805

Remove a return preventing DH params to be generated.
This was introduced by commit 74151247

Tuleap: #792
Change-Id: I131166f7fef655d93425d10da59af04d6104e7f6

SdesNegotiator::negotiate() does an invalid check on given offered crypto-suite.
The current setup is made in a way that this function always returns
the remote crypto suite, supported or not! Dangerous.

This patch fixes that by correctly comparing crypto-suite names.

Change-Id: I0ef022486e00b5fef91d2552b83d57463282a683
Tuleap: #747

archiver::compress used to rely on compressBound, but the actual
compressed size might be smaller, leading to larger output (with
trailing zeroes).

Change-Id: Ic33614f2d6bc648e59a76dec7275e71466ecaff1
Tuleap: #888

This patch reduces the maximal payload of all UDP stream to 1232 bytes.
This value is computed from the minimal MTU requested by rfc 2460
to support IPv6.
This value ensures that common networks (going to IPv6) support
a large enough packet size to be efficient, but a minimal size to
not be fragmented. This last case has a great incidence on packet drop
and reordering and validated by heuristic.

Change-Id: Icee79bb25b2fdcc70fef3efb4527209f8309be61
Tuleap: #887

Andreas Traczyk authored 8 years ago and Andreas Traczyk committed 8 years ago

Add a Microsoft port of dirent.h to support directory parsing
functionality. It is named windirent.h to avoid cases where the
compiler searches for headers in local directories first regardless
of chevron wrapping.

File source: https://github.com/tronkko/dirent
commit bf060f1569b156a6df15ea01ea0b4b5465243f06

Change-Id: I45bcf59883949a390b5471b62013a6d95d36903e
Tuleap: #799

* Add Microsoft compiler support;
* Work around the issue compiling on Apple's LLVM 7.3.0;
* Add Network id feature;
* License OpenDHT compatible with GPL>=3;
* Adding cryptographic API;
* Consistent library naming between diffrent build tools.

Change-Id: I4e7a53619d89f7b2034326ea8d5f75848335c533
Tuleap: #556

The new --no-checksums parameter allows for skipping checksums
verifications. This can be used to replace tarballs and still use the
contrib system.

This is useful for atleast the two following cases:

 - Distro developper needs contrib to patch the source, but has the
   original source in the distribution.

 - Distro developper repacks the source, breaking the checksum.

Change-Id: I015ce3d0f6f4fb2f5fd5ec2f95528bfb4b045298
Tuleap: #879

In reaction to Debian bug:
 - https://bugs.debian.org/831978

Accoding to the FHS[1]:
  Utilities used for system administration (and other root-only
  commands) are stored in /sbin, /usr/sbin, and /usr/local/sbin. /sbin
  contains binaries essential for booting, restoring, recovering, and/or
  repairing the system in addition to the binaries in /bin. [18]
  Programs executed after /usr is known to be mounted (when there are no
  problems) are generally placed into /usr/sbin. Locally-installed
  system administration programs should be placed into
  /usr/local/sbin.

1. https://www.debian.org/doc/packaging-manuals/fhs/fhs-2.3.html#SBINSYSTEMBINARIES

Change-Id: I13e16eb0e7750fc84d5f44c53da63ad0aebbe240
Tuleap: #860

Will properly check for a valid PMP IGD,
clear and reopen ports in case of connectivity change.

Change-Id: I47acfa9027217f5ba9f6c6c5b99d46abf5908e31
Tuleap: #805
Tuleap: #841

* add optional dependency to libnatpmp
* can run with or without UPnP
* transparently replaces UPnP when available

Change-Id: I1bbded421833cdc2506b42106e30cc8b3dde4c2d
Tuleap: #805

Original file name:
 - 171324__swidmark__ringtone.wav

Download location:
 - https://freesound.org/people/swidmark/sounds/171324

Uploader:
 - https://freesound.org/people/swidmark

License:
 - CC0 1.0 Universal (CC0 1.0)
 - https://creativecommons.org/publicdomain/zero/1.0

Change-Id: Ib521d600fd84d9038d80db8db2c32cb31817775d
Tuleap: #868

Tuleap: #874
Change-Id: Icb0586a0a8b15cd7131243b6f1b819054ab4829d

This allows the clients to notify the daemon when the conenctivity
(ie: network status) has changed. The daemon will then try to detect
the new IGD (UPnP) and re-connect all enabled accounts.

Change-Id: I5c8fc57f75e48d86eda5d195b0586c61a26134ad
Tuleap: #841

Simon Zeni authored 8 years ago and Guillaume Roguez committed 8 years ago

This fix the infinite loop at the call of the function
pinCertificate using a vector<uint8_t> as an argment

Change-Id: Ifc30c925e85d745dea3d76066dd547065cd0760d
Tuleap: #861

Provide better cross platform compiler compliance by using c++11
standard library's std::this_thread::sleep_for.

Change-Id: Ib0ef9bec8336ae620315c05b53706e4605ab00fb
Tuleap: #794

aviau authored 8 years ago and Guillaume Roguez committed 8 years ago

This adds the support for the DISABLE_CONTRIB_DOWNLOADS environment
variable. It if it set to TRUE, the contrib system will not download
tarballs from the internet.

It can be set from the bootstrap script with the --disable-downloads
option.

This is useful for distro packaging because distribution developpers
have to make sure they have full control of what is included in the
package. In Debian, some tarballs are included such as pjsip but the
rest should not be downloaded. A small mistake such as a missging build
dependency could cause a tarball download. This new options will help
pervent such issues.

Tuleap: #847
Change-Id: I5f579774c53def751111f9366750670fcd75d893

* Permanent 'put' feature;
* Enhanced search's nodes handler algorithm;
* fix bug when IPv[46] empty table, would not call some callbacks;
* man page for dhtnode;
* support for make DESTDIR= syntax;

Change-Id: I0ae58edb706a6344a45fc7c254c7cd29ef8bc90a
Reviewed-by: Edric Milaret <edric.ladent-milaret@savoirfairelinux.com>

Some functions in SIPStartCall can take a long time to return, such
as ICE initialization. This allows the manager to return the callId
in outgoingCall() to the client sooner and so prevents the UI from
freezing.

Change-Id: I87b0c4b5d56f69e087f0117b2b78daa026679aab
Tuleap: #620

This way we don't have to wait for the ICE init before the manager
can get a callId to return to the client. The ICE init can take a long
time in certain cases (eg: bad TURN password, slow UPnP) which causes
the UI to freeze while waiting for the daemon to return outgoingCall()
with the callId.

Note this changes the behaviour of the daemon slightly. Before if the
ICE init failed then no callId would be returned. Now the callId is
always returned and the call will later emit a state change of Fail if
the ICE init fails.

Tuleap: #620
Change-Id: I712d1d52be9e9b809b794bb7694ad31bdd2e3bb1

The code of Manager::addTask() has a comment
about the fact that this function is not thread-safe
and must be called by the same thread calling Manager::pollEvent().
But many part of code seem not taking in account this notice
and call it outside of the correct thread.

This ticket fixes this by using a mutex.

Change-Id: I82d4cc2d6f26c1157caae0e4826dbf96a73561c6
Tuleap: #837